OpenVZ Forum: Devel » [PATCH] remove BUG() in possible but rare condition

Home » Mailing lists » Devel » [PATCH] remove BUG() in possible but rare condition

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH] remove BUG() in possible but rare condition [message #45905 is a reply to message #45895]

Wed, 11 April 2012 21:33

Jiri Kosina
Messages: 1
Registered: April 2012

Junior Member

On Wed, 11 Apr 2012, Linus Torvalds wrote:

> > I am not familiar with the code much but a trivial call chain walk up to
> > write_dev_supers (in btrfs) shows that we do not check for the return value
> > from __getblk so we would nullptr and there might be more.
> > I guess these need some treat before the BUG might be removed, right?
>
> Well, realistically, isn't BUG() as bad as a NULL pointer dereference?

Well, there still could be weirdos out there not setting
sys.vm.mmap_min_addr to something sane. For those, NULL pointer
dereference could have worse consequences than BUG (unlikely in this
particular case, yes).

--
Jiri Kosina
SUSE Labs

Report message to a moderator

[Message index]

		[PATCH] remove BUG() in possible but rare condition By: Glauber Costa on Wed, 11 April 2012 18:10
		Re: [PATCH] remove BUG() in possible but rare condition By: Michal Hocko on Wed, 11 April 2012 18:48
		Re: [PATCH] remove BUG() in possible but rare condition By: Linus Torvalds on Wed, 11 April 2012 18:57
		Re: [PATCH] remove BUG() in possible but rare condition By: Glauber Costa on Wed, 11 April 2012 19:02
		Re: [PATCH] remove BUG() in possible but rare condition By: Michal Hocko on Wed, 11 April 2012 19:25
		Re: [PATCH] remove BUG() in possible but rare condition By: Michal Hocko on Wed, 11 April 2012 19:20
		Re: [PATCH] remove BUG() in possible but rare condition By: Jiri Kosina on Wed, 11 April 2012 21:33
		Re: [PATCH] remove BUG() in possible but rare condition By: Glauber Costa on Wed, 11 April 2012 18:59
		Re: [PATCH] remove BUG() in possible but rare condition By: akpm on Wed, 11 April 2012 20:26
		Re: [PATCH] remove BUG() in possible but rare condition By: Glauber Costa on Wed, 11 April 2012 20:51
		Re: [PATCH] remove BUG() in possible but rare condition By: akpm on Wed, 11 April 2012 21:12
		Re: [PATCH] remove BUG() in possible but rare condition By: Michal Hocko on Wed, 11 April 2012 21:26
		Re: [PATCH] remove BUG() in possible but rare condition By: Michal Hocko on Thu, 12 April 2012 09:24

Previous Topic:	[PATCH 0/4] nfsd: containerize export and expkey caches
Next Topic:	[PATCH] slub: don't create a copy of the name string in kmem_cache_create

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Tue Jul 28 13:02:56 GMT 2026

Total time taken to generate the page: 1.08859 seconds