OpenVZ Forum: Devel » [PATCH] remove BUG() in possible but rare condition

Home » Mailing lists » Devel » [PATCH] remove BUG() in possible but rare condition

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH] remove BUG() in possible but rare condition [message #45903 is a reply to message #45902]

Wed, 11 April 2012 21:26

Michal Hocko
Messages: 109
Registered: December 2011

Senior Member

On Wed 11-04-12 14:12:44, Andrew Morton wrote:
> On Wed, 11 Apr 2012 17:51:57 -0300
> Glauber Costa <glommer@parallels.com> wrote:
>
> > On 04/11/2012 05:26 PM, Andrew Morton wrote:
> > >>
> > >> > failed:
> > >> > - BUG();
> > >> > unlock_page(page);
> > >> > page_cache_release(page);
> > >> > return NULL;
> > > Cute.
> > >
> > > AFAICT what happened was that in my April 2002 rewrite of this code I
> > > put a non-fatal buffer_error() warning in that case to tell us that
> > > something bad happened.
> > >
> > > Years later we removed the temporary buffer_error() and mistakenly
> > > replaced that warning with a BUG(). Only it*can* happen.
> > >
> > > We can remove the BUG() and fix up callers, or we can pass retry=1 into
> > > alloc_page_buffers(), so grow_dev_page() "cannot fail". Immortal
> > > functions are a silly fiction, so we should remove the BUG() and fix up
> > > callers.
> > >
> > Any particular caller you are concerned with ?
>
> Didn't someone see a buggy caller in btrfs?

No I missed that __getblk (__getblk_slow) returns NULL only if
grow_buffers < 0 while it returns 0 for the allocation failure.

Sorry for confusion.
--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic

Report message to a moderator

[Message index]

		[PATCH] remove BUG() in possible but rare condition By: Glauber Costa on Wed, 11 April 2012 18:10
		Re: [PATCH] remove BUG() in possible but rare condition By: Michal Hocko on Wed, 11 April 2012 18:48
		Re: [PATCH] remove BUG() in possible but rare condition By: Linus Torvalds on Wed, 11 April 2012 18:57
		Re: [PATCH] remove BUG() in possible but rare condition By: Glauber Costa on Wed, 11 April 2012 19:02
		Re: [PATCH] remove BUG() in possible but rare condition By: Michal Hocko on Wed, 11 April 2012 19:25
		Re: [PATCH] remove BUG() in possible but rare condition By: Michal Hocko on Wed, 11 April 2012 19:20
		Re: [PATCH] remove BUG() in possible but rare condition By: Jiri Kosina on Wed, 11 April 2012 21:33
		Re: [PATCH] remove BUG() in possible but rare condition By: Glauber Costa on Wed, 11 April 2012 18:59
		Re: [PATCH] remove BUG() in possible but rare condition By: akpm on Wed, 11 April 2012 20:26
		Re: [PATCH] remove BUG() in possible but rare condition By: Glauber Costa on Wed, 11 April 2012 20:51
		Re: [PATCH] remove BUG() in possible but rare condition By: akpm on Wed, 11 April 2012 21:12
		Re: [PATCH] remove BUG() in possible but rare condition By: Michal Hocko on Wed, 11 April 2012 21:26
		Re: [PATCH] remove BUG() in possible but rare condition By: Michal Hocko on Thu, 12 April 2012 09:24

Previous Topic:	[PATCH 0/4] nfsd: containerize export and expkey caches
Next Topic:	[PATCH] slub: don't create a copy of the name string in kmem_cache_create

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Thu Apr 23 01:43:23 GMT 2026

Total time taken to generate the page: 0.45529 seconds