OpenVZ Forum: Devel » [PATCH 0/7] memcg kernel memory tracking

Home » Mailing lists » Devel » [PATCH 0/7] memcg kernel memory tracking

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH 1/7] small cleanup for memcontrol.c [message #45391 is a reply to message #45385]

Thu, 01 March 2012 02:11

KAMEZAWA Hiroyuki
Messages: 463
Registered: September 2006

Senior Member

On Wed, 29 Feb 2012 14:30:35 -0300
Glauber Costa <glommer@parallels.com> wrote:

> On 02/22/2012 12:01 PM, Glauber Costa wrote:
> > On 02/22/2012 04:46 AM, KAMEZAWA Hiroyuki wrote:
> >> On Tue, 21 Feb 2012 15:34:33 +0400
> >> Glauber Costa<glommer@parallels.com> wrote:
> >>
> >>> Move some hardcoded definitions to an enum type.
> >>>
> >>> Signed-off-by: Glauber Costa<glommer@parallels.com>
> >>> CC: Kirill A. Shutemov<kirill@shutemov.name>
> >>> CC: Greg Thelen<gthelen@google.com>
> >>> CC: Johannes Weiner<jweiner@redhat.com>
> >>> CC: Michal Hocko<mhocko@suse.cz>
> >>> CC: Hiroyouki Kamezawa<kamezawa.hiroyu@jp.fujitsu.com>
> >>> CC: Paul Turner<pjt@google.com>
> >>> CC: Frederic Weisbecker<fweisbec@gmail.com>
> >>
> >> seems ok to me.
> >>
> >> Acked-by: KAMEZAWA Hiroyuki<kamezawa.hiroyu@jp.fujitsu.com>
> >
> > BTW, this series is likely to go through many rounds of discussion.
> > This patch can be probably picked separately, if you want to.
> >
> >> a nitpick..
> >>
> >>> ---
> >>> mm/memcontrol.c | 10 +++++++---
> >>> 1 files changed, 7 insertions(+), 3 deletions(-)
> >>>
> >>> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> >>> index 6728a7a..b15a693 100644
> >>> --- a/mm/memcontrol.c
> >>> +++ b/mm/memcontrol.c
> >>> @@ -351,9 +351,13 @@ enum charge_type {
> >>> };
> >>>
> >>> /* for encoding cft->private value on file */
> >>> -#define _MEM (0)
> >>> -#define _MEMSWAP (1)
> >>> -#define _OOM_TYPE (2)
> >>> +
> >>> +enum mem_type {
> >>> + _MEM = 0,
> >>
> >> =0 is required ?
> > I believe not, but I always liked to use it to be 100 % explicit.
> > Personal taste... Can change it, if this is a big deal.
>
> Kame, would you like me to send this cleanup without the = 0 ?
>

Not necessary. Sorry for delayed response.
Lots of memcg patches are flying..

Thanks,
-Kame

Report message to a moderator

[Message index]

		[PATCH 0/7] memcg kernel memory tracking By: Glauber Costa on Tue, 21 February 2012 11:34
		[PATCH 2/7] Basic kernel memory functionality for the Memory Controller By: Glauber Costa on Tue, 21 February 2012 11:34
		[PATCH 1/7] small cleanup for memcontrol.c By: Glauber Costa on Tue, 21 February 2012 11:34
		Re: [PATCH 1/7] small cleanup for memcontrol.c By: KAMEZAWA Hiroyuki on Wed, 22 February 2012 00:46
		Re: [PATCH 1/7] small cleanup for memcontrol.c By: Glauber Costa on Wed, 22 February 2012 14:01
		Re: [PATCH 1/7] small cleanup for memcontrol.c By: Glauber Costa on Wed, 29 February 2012 17:30
		Re: [PATCH 1/7] small cleanup for memcontrol.c By: KAMEZAWA Hiroyuki on Thu, 01 March 2012 02:11
		[PATCH 3/7] per-cgroup slab caches By: Glauber Costa on Tue, 21 February 2012 11:34
		Re: [PATCH 3/7] per-cgroup slab caches By: KAMEZAWA Hiroyuki on Wed, 22 February 2012 01:21
		Re: [PATCH 3/7] per-cgroup slab caches By: Glauber Costa on Wed, 22 February 2012 14:25
		Re: [PATCH 3/7] per-cgroup slab caches By: Glauber Costa on Wed, 22 February 2012 14:08
		Re: [PATCH 3/7] per-cgroup slab caches By: Suleiman Souhlal on Tue, 21 February 2012 23:50
		[PATCH 4/7] chained slab caches: move pages to a different cache when a cache is destroyed. By: Glauber Costa on Tue, 21 February 2012 11:34
		Re: [PATCH 4/7] chained slab caches: move pages to a different cache when a cache is destroyed. By: KAMEZAWA Hiroyuki on Wed, 22 February 2012 01:25
		Re: [PATCH 4/7] chained slab caches: move pages to a different cache when a cache is destroyed. By: Glauber Costa on Wed, 22 February 2012 14:57
		Re: [PATCH 4/7] chained slab caches: move pages to a different cache when a cache is destroyed. By: Glauber Costa on Wed, 22 February 2012 14:50
		Re: [PATCH 4/7] chained slab caches: move pages to a different cache when a cache is destroyed. By: Suleiman Souhlal on Tue, 21 February 2012 23:40
		[PATCH 5/7] shrink support for memcg kmem controller By: Glauber Costa on Tue, 21 February 2012 11:34
		Re: [PATCH 5/7] shrink support for memcg kmem controller By: KAMEZAWA Hiroyuki on Wed, 22 February 2012 01:42
		Re: [PATCH 5/7] shrink support for memcg kmem controller By: Glauber Costa on Wed, 22 February 2012 14:53
		Re: [PATCH 5/7] shrink support for memcg kmem controller By: Glauber Costa on Wed, 22 February 2012 14:00
		Re: [PATCH 5/7] shrink support for memcg kmem controller By: Suleiman Souhlal on Tue, 21 February 2012 23:35
		[PATCH 6/7] track dcache per-memcg By: Glauber Costa on Tue, 21 February 2012 11:34
		[PATCH 7/7] example shrinker for memcg-aware dcache By: Glauber Costa on Tue, 21 February 2012 11:34
		Re: [PATCH 0/7] memcg kernel memory tracking By: Glauber Costa on Wed, 22 February 2012 13:58
		Re: [PATCH 0/7] memcg kernel memory tracking By: Suleiman Souhlal on Wed, 22 February 2012 20:32
		Re: [PATCH 0/7] memcg kernel memory tracking By: Glauber Costa on Wed, 22 February 2012 14:11
		Re: [PATCH 0/7] memcg kernel memory tracking By: Ying Han on Thu, 23 February 2012 18:18
		Re: [PATCH 0/7] memcg kernel memory tracking By: Glauber Costa on Tue, 28 February 2012 19:02
		Re: [PATCH 0/7] memcg kernel memory tracking By: Suleiman Souhlal on Tue, 21 February 2012 23:25
		Re: [PATCH 0/7] memcg kernel memory tracking By: Pekka Enberg on Wed, 22 February 2012 07:08

Previous Topic:	Re: [PATCH 00/10] memcg: Kernel Memory Accounting.
Next Topic:	Re: [PATCH 04/10] memcg: Introduce __GFP_NOACCOUNT.

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Fri Aug 22 00:04:32 GMT 2025

Total time taken to generate the page: 0.08239 seconds