OpenVZ Forum: Devel » [PATCH] fdset's leakage

Home » Mailing lists » Devel » [PATCH] fdset's leakage

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH] fdset's leakage [message #4495 is a reply to message #4494]

Tue, 11 July 2006 17:26

Eric Dumazet
Messages: 36
Registered: July 2006

Member

On Tuesday 11 July 2006 18:13, Vadim Lobanov wrote:
> > unsinged long round_up_pow_of_two(unsigned long x)
> > {
> > unsigned long res = 1 << BITS_PER_LONG;
>
> You'll get a zero here. Should be 1 << (BITS_PER_LONG - 1).
>

Nope. It wont work on 64 bits platform :)

You want 1UL << (BITS_PER_LONG - 1).

But the roundup_pow_of_two() function is already defined in
include/linux/kernel.h and uses fls_long()

Eric

Report message to a moderator

[Message index]

		[PATCH] fdset's leakage By: Kirill Korotaev on Mon, 10 July 2006 13:40
		Re: [PATCH] fdset's leakage By: Andrew Morton on Tue, 11 July 2006 08:01
		Re: [PATCH] fdset's leakage By: Kirill Korotaev on Tue, 11 July 2006 09:05
		Re: [PATCH] fdset's leakage By: Andrew Morton on Tue, 11 July 2006 09:28
		Re: [PATCH] fdset's leakage By: Vadim Lobanov on Tue, 11 July 2006 16:13
		Re: [PATCH] fdset's leakage By: Eric Dumazet on Tue, 11 July 2006 17:26
		Re: [PATCH] fdset's leakage By: dev on Wed, 12 July 2006 10:49
		Re: [PATCH] fdset's leakage By: Rene Scharfe on Tue, 11 July 2006 09:02

Previous Topic:	[PATCH] struct file leakage
Next Topic:	Container Test Campaign

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Thu Apr 16 07:40:40 GMT 2026

Total time taken to generate the page: 0.59862 seconds