OpenVZ Forum: Devel » [PATCH v5 00/10] per-cgroup tcp memory pressure

Home » Mailing lists » Devel » [PATCH v5 00/10] per-cgroup tcp memory pressure

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: Re: [PATCH v5 00/10] per-cgroup tcp memory pressure [message #44121 is a reply to message #44092]

Thu, 17 November 2011 21:35

davem
Messages: 463
Registered: February 2006

Senior Member

From: James Bottomley <jbottomley@parallels.com>
Date: Tue, 15 Nov 2011 18:27:12 +0000

> Ping on this, please. We're blocked on this patch set until we can get
> an ack that the approach is acceptable to network people.

__sk_mem_schedule is now more expensive, because instead of short-circuiting
the majority of the function's logic when "allocated <= prot->sysctl_mem[0]"
and immediately returning 1, the whole rest of the function is run.

The static branch protecting all of the cgroup code seems to be
enabled if any memory based cgroup'ing is enabled. What if people use
the memory cgroup facility but not for sockets? I am to understand
that, of the very few people who are going to use this stuff in any
capacity, this would be a common usage.

TCP specific stuff in mm/memcontrol.c, at best that's not nice at all.

Otherwise looks mostly good.

Report message to a moderator

[Message index]

		[PATCH v5 00/10] per-cgroup tcp memory pressure By: Glauber Costa on Mon, 07 November 2011 15:26
		[PATCH v5 01/10] Basic kernel memory functionality for the Memory Controller By: Glauber Costa on Mon, 07 November 2011 15:26
		[PATCH v5 02/10] foundations of per-cgroup memory pressure controlling. By: Glauber Costa on Mon, 07 November 2011 15:26
		[PATCH v5 03/10] socket: initial cgroup code. By: Glauber Costa on Mon, 07 November 2011 15:26
		[PATCH v5 05/10] per-netns ipv4 sysctl_tcp_mem By: Glauber Costa on Mon, 07 November 2011 15:26
		[PATCH v5 07/10] Display current tcp memory allocation in kmem cgroup By: Glauber Costa on Mon, 07 November 2011 15:26
		[PATCH v5 06/10] tcp buffer limitation: per-cgroup limit By: Glauber Costa on Mon, 07 November 2011 15:26
		[PATCH v5 10/10] Disable task moving when using kernel memory accounting By: Glauber Costa on Mon, 07 November 2011 15:26
		[PATCH v5 08/10] Display current tcp memory allocation in kmem cgroup By: Glauber Costa on Mon, 07 November 2011 15:26
		[PATCH v5 09/10] Display current tcp memory allocation in kmem cgroup By: Glauber Costa on Mon, 07 November 2011 15:26
		[PATCH v5 04/10] per-cgroup tcp buffers control By: Glauber Costa on Mon, 07 November 2011 15:26
		RE: [PATCH v5 04/10] per-cgroup tcp buffers control By: Glauber Costa on Mon, 07 November 2011 17:28
		Re: [PATCH v5 00/10] per-cgroup tcp memory pressure By: Glauber Costa on Wed, 09 November 2011 18:02
		Re: Re: [PATCH v5 00/10] per-cgroup tcp memory pressure By: James Bottomley on Tue, 15 November 2011 18:27
		Re: Re: [PATCH v5 00/10] per-cgroup tcp memory pressure By: davem on Thu, 17 November 2011 21:35
		Re: Re: [PATCH v5 00/10] per-cgroup tcp memory pressure By: Glauber Costa on Fri, 18 November 2011 19:39
		Re: Re: [PATCH v5 00/10] per-cgroup tcp memory pressure By: davem on Fri, 18 November 2011 19:51
		Re: Re: [PATCH v5 00/10] per-cgroup tcp memory pressure By: KAMEZAWA Hiroyuki on Tue, 22 November 2011 02:07
		Re: Re: [PATCH v5 00/10] per-cgroup tcp memory pressure By: Glauber Costa on Wed, 23 November 2011 10:25

Previous Topic:	Profitez d'un site internet professionnel
Next Topic:	[PATCH 0/6] SUNRPC: make RPC clients use network-namespace-aware PipeFS routines

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sun Dec 14 00:48:23 GMT 2025

Total time taken to generate the page: 0.10548 seconds