OpenVZ Forum


Home » Mailing lists » Devel » [PATCH] remove load balance warning
[PATCH] remove load balance warning [message #427] Thu, 01 December 2005 10:57
dev is currently offline  dev
Messages: 1693
Registered: September 2005
Location: Moscow
Senior Member

Patch from Kirill (dev@):
This patch removes warning on load balance.
Balancing is racy, and it is not fatal anyhow if busiest rq is the
current one. printk() under rq->lock can be the much more fatal thing
here...

Kirill

--- ./kernel/sched.c.loadbal 2005-11-25 22:04:23.000000000 +0300
+++ ./kernel/sched.c 2005-12-01 13:55:28.000000000 +0300
@@ -2586,10 +2586,8 @@ static int load_balance(vcpu_t this_cpu,
* balancing is inherently racy and statistical,
* it could happen in theory.
*/
- if (unlikely(busiest == this_rq)) {
- WARN_ON(1);
+ if (unlikely(busiest == this_rq))
goto out_balanced;
- }

nr_moved = 0;
if (busiest->nr_running > 1) {
Previous Topic: [PATCH] Print setsockopt warning to ve log
Next Topic: [PATCH] quota debug extend
Goto Forum:
  


Current Time: Fri Aug 15 21:43:50 GMT 2025

Total time taken to generate the page: 0.27597 seconds