OpenVZ Forum


Home » Mailing lists » Devel » [PATCH] cgroup: Remove call to synchronize_rcu in cgroup_attach_task
Re: [PATCH] cgroup: Remove call to synchronize_rcu in cgroup_attach_task [message #41922 is a reply to message #41920] Wed, 24 November 2010 02:29 Go to previous messageGo to previous message
Colin Cross is currently offline  Colin Cross
Messages: 15
Registered: November 2010
Junior Member
On Tue, Nov 23, 2010 at 5:43 PM, Colin Cross <ccross@android.com> wrote:
> This patch is similar to what you described.  The main differences are
> that I used a new atomic to handle the rmdir case, and I converted
> check_for_release to be callable in softirq context rather than schedule
> work in free_css_set_rcu.  Your css_set scanning in rmdir sounds better,
> I'll take another look at that.  Is there any problem with disabling irqs
> with spin_lock_irqsave in check_for_release?

free_css_set_rcu needs to take a write lock on css_set_lock to protect the
list_del(&link->cgrp_link_list). I'll convert it to schedule work, and change
the spin_lock_irqsave back to spin_lock.
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containe rs

Report message to a moderator

[Message index]
 
Read Message
Read Message
Read Message
Read Message
Read Message
Previous Topic: [PATCH v3 00/16] make rpc_pipefs be mountable multiple time
Next Topic: [PATCH] cgroup: Remove RCU from task-&gt;cgroups
Goto Forum:
  

[ Syndicate this forum (XML) ] [ RSS ] [ PDF ]

Current Time: Mon Oct 27 04:40:06 GMT 2025

Total time taken to generate the page: 0.10831 seconds
Powered by FUDforum Powered by Virtuozzo Containers