OpenVZ Forum


Home » Mailing lists » Devel » Re: [PATCH] cgroup: prefer [kv]zalloc over [kv]malloc+memset in memory controller code.
Re: [PATCH] cgroup: prefer [kv]zalloc over [kv]malloc+memset in memory controller code. [message #41900] Mon, 01 November 2010 20:01 Go to previous message
Johannes Weiner is currently offline  Johannes Weiner
Messages: 9
Registered: November 2010
Junior Member
On Mon, Nov 01, 2010 at 08:40:56PM +0100, Jesper Juhl wrote:
> Hi (please CC me on replies),
>
>
> Apologies to those who receive this multiple times. I screwed up the To:
> field in my original mail :-(
>
>
> In mem_cgroup_alloc() we currently do either kmalloc() or vmalloc() then
> followed by memset() to zero the memory. This can be more efficiently
> achieved by using kzalloc() and vzalloc().
>
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>

Looks good to me, but there is also the memset after kmalloc in
alloc_mem_cgroup_per_zone_info(). Can you switch that over as well in
this patch? You can pass __GFP_ZERO to kmalloc_node() for zeroing.

Thanks!
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containe rs

Report message to a moderator

[Message index]
 
Read Message
Read Message
Previous Topic: [PATCH] cgroup: prefer [kv]zalloc over [kv]malloc+memset in memory controller code.
Next Topic: Re: [PATCH] cgroup: prefer [kv]zalloc over [kv]malloc+memset in memory controller code.
Goto Forum:
  

[ Syndicate this forum (XML) ] [ RSS ] [ PDF ]

Current Time: Wed Nov 26 20:06:35 GMT 2025

Total time taken to generate the page: 0.35510 seconds
Powered by FUDforum Powered by Virtuozzo Containers