Home » Mailing lists » Devel » [RFC] vzctl 'make install' target
| [RFC] vzctl 'make install' target [message #4132] |
Thu, 29 June 2006 09:03  |
|
|
Problem: currently vzctl's "make install" install some redhat-specific
stuff, like /etc/sysconfig/network-scripts/*venet* files and
/etc/init.d/vz initscript. This creates a problem for distros such as
Gentoo and Debian. Currently, for example, Gentoo solves that by
patching Makefile.
We want to fix it in next vzctl release. There are several solutions
possible:
(1) rename 'install' target to install-redhat, and add generic 'install'
target which will not install initscript and
/etc/sysconfig/network-scripts/*venet0* stuff
(2) leave install target as is and add 'install-generic' target which
will do the same as 'install' from (1)
(3) try to determine distro during runtime, from Makefile itself, and
act appropriately
(4) Pass some params to Makefile in environment, like SKIP_NETSCRIPTS or
SKIP_INITSCRIPT
(5) a variation of (1) -- add install-generic and install-redhat target,
do nothing but print a list of possible install-* target on invocation
of 'make install'.
I prefer #5. What do people think? I am especially interested in hearing
from Debian and Gentoo maintainers.
|
|
|
|
| Re: [RFC] vzctl 'make install' target [message #4137 is a reply to message #4132] |
Thu, 29 June 2006 11:00  |
Christian Heim
Messages: 4
Registered: February 2006
|
Junior Member |
|
|
On Thursday 29 June 2006 11:03, Kir Kolyshkin wrote:
>We want to fix it in next vzctl release. There are several solutions
>possible:
>
>(1) rename 'install' target to install-redhat, and add generic 'install'
>target which will not install initscript and
>/etc/sysconfig/network-scripts/*venet0* stuff
>
>(2) leave install target as is and add 'install-generic' target which
>will do the same as 'install' from (1)
>
>(3) try to determine distro during runtime, from Makefile itself, and
>act appropriately
>
>(4) Pass some params to Makefile in environment, like SKIP_NETSCRIPTS or
>SKIP_INITSCRIPT
>
>(5) a variation of (1) -- add install-generic and install-redhat target,
>do nothing but print a list of possible install-* target on invocation
>of 'make install'.
>
>I prefer #5. What do people think? I am especially interested in hearing
>from Debian and Gentoo maintainers.
Well, we don't prefer any specific, so #1, #2 or #5 would be fine with us.
It's after all _your_ package ;)
TIA, Christian
--
Christian Heim <phreak@gentoo.org>
Gentoo Linux Developer - vserver/openvz
|
|
|
|
| Re: Re: [RFC] vzctl 'make install' target [message #4185 is a reply to message #4137] |
Fri, 30 June 2006 22:50 |
ldv
Messages: 24
Registered: June 2006
|
Junior Member |
|
|
On Thu, Jun 29, 2006 at 01:00:28PM +0200, Christian Heim wrote:
> On Thursday 29 June 2006 11:03, Kir Kolyshkin wrote:
> >We want to fix it in next vzctl release. There are several solutions
> >possible:
> >
> >(1) rename 'install' target to install-redhat, and add generic 'install'
> >target which will not install initscript and
> >/etc/sysconfig/network-scripts/*venet0* stuff
> >
> >(2) leave install target as is and add 'install-generic' target which
> >will do the same as 'install' from (1)
> >
> >(3) try to determine distro during runtime, from Makefile itself, and
> >act appropriately
> >
> >(4) Pass some params to Makefile in environment, like SKIP_NETSCRIPTS or
> >SKIP_INITSCRIPT
> >
> >(5) a variation of (1) -- add install-generic and install-redhat target,
> >do nothing but print a list of possible install-* target on invocation
> >of 'make install'.
> >
> >I prefer #5. What do people think? I am especially interested in hearing
> >from Debian and Gentoo maintainers.
>
> Well, we don't prefer any specific, so #1, #2 or #5 would be fine with us.
Likewise. My advice is to avoid #3.
> It's after all _your_ package ;)
It sounds like "do whatever you want, we'll patch our package anyway" :)
--
ldv
|
|
|
|
| Re: [RFC] vzctl 'make install' target [message #4192 is a reply to message #4185] |
Sat, 01 July 2006 17:30 |
Christian Heim
Messages: 4
Registered: February 2006
|
Junior Member |
|
|
On Saturday 01 July 2006 00:50, Dmitry V. Levin wrote:
>On Thu, Jun 29, 2006 at 01:00:28PM +0200, Christian Heim wrote:
>> On Thursday 29 June 2006 11:03, Kir Kolyshkin wrote:
>> >We want to fix it in next vzctl release. There are several solutions
>> >possible:
>> >
>> >(1) rename 'install' target to install-redhat, and add generic 'install'
>> >target which will not install initscript and
>> >/etc/sysconfig/network-scripts/*venet0* stuff
>> >
>> >(2) leave install target as is and add 'install-generic' target which
>> >will do the same as 'install' from (1)
>> >
>> >(3) try to determine distro during runtime, from Makefile itself, and
>> >act appropriately
>> >
>> >(4) Pass some params to Makefile in environment, like SKIP_NETSCRIPTS or
>> >SKIP_INITSCRIPT
>> >
>> >(5) a variation of (1) -- add install-generic and install-redhat target,
>> >do nothing but print a list of possible install-* target on invocation
>> >of 'make install'.
>> >
>> >I prefer #5. What do people think? I am especially interested in hearing
>> >from Debian and Gentoo maintainers.
>>
>> Well, we don't prefer any specific, so #1, #2 or #5 would be fine with us.
>
>Likewise. My advice is to avoid #3.
Well even if it sounds nice, #3 would be a real pain in the ass (not for me).
>> It's after all _your_ package ;)
>
>It sounds like "do whatever you want, we'll patch our package anyway" :)
Nah, we'll use whatever you guys come up with :P (at least regarding #1, #2
and #5).
--
Christian Heim <phreak@gentoo.org>
Gentoo Linux Developer - vserver/openvz
|
|
|
|
| Re: [RFC] vzctl 'make install' target [message #4322 is a reply to message #4192] |
Wed, 05 July 2006 15:53 |
Ola Lundqvist
Messages: 15
Registered: April 2006
|
Junior Member |
|
|
Hi
I would more or less just say AOL. That is please avoid #3.
My suggestion is to have an 'install' target that install the generic
stuff, and then install-redhat, install-debian, etc for only the distribution
specific things. This would be an alternative option 6. :) But it do not
really matter much as Debian is quite flexible what you can do around
upstream packaging...
Regards,
// Ola
On Sat, Jul 01, 2006 at 07:30:01PM +0200, Christian Heim wrote:
> On Saturday 01 July 2006 00:50, Dmitry V. Levin wrote:
> >On Thu, Jun 29, 2006 at 01:00:28PM +0200, Christian Heim wrote:
> >> On Thursday 29 June 2006 11:03, Kir Kolyshkin wrote:
> >> >We want to fix it in next vzctl release. There are several solutions
> >> >possible:
> >> >
> >> >(1) rename 'install' target to install-redhat, and add generic 'install'
> >> >target which will not install initscript and
> >> >/etc/sysconfig/network-scripts/*venet0* stuff
> >> >
> >> >(2) leave install target as is and add 'install-generic' target which
> >> >will do the same as 'install' from (1)
> >> >
> >> >(3) try to determine distro during runtime, from Makefile itself, and
> >> >act appropriately
> >> >
> >> >(4) Pass some params to Makefile in environment, like SKIP_NETSCRIPTS or
> >> >SKIP_INITSCRIPT
> >> >
> >> >(5) a variation of (1) -- add install-generic and install-redhat target,
> >> >do nothing but print a list of possible install-* target on invocation
> >> >of 'make install'.
> >> >
> >> >I prefer #5. What do people think? I am especially interested in hearing
> >> >from Debian and Gentoo maintainers.
> >>
> >> Well, we don't prefer any specific, so #1, #2 or #5 would be fine with us.
> >
> >Likewise. My advice is to avoid #3.
>
> Well even if it sounds nice, #3 would be a real pain in the ass (not for me).
>
> >> It's after all _your_ package ;)
> >
> >It sounds like "do whatever you want, we'll patch our package anyway" :)
>
> Nah, we'll use whatever you guys come up with :P (at least regarding #1, #2
> and #5).
>
> --
> Christian Heim <phreak@gentoo.org>
> Gentoo Linux Developer - vserver/openvz
--
--- Ola Lundqvist systemkonsult --- M Sc in IT Engineering ----
/ ola@opalsys.net Annebergsslingan 37 \
| opal@debian.org 654 65 KARLSTAD |
| http://www.opal.dhs.org Mobile: +46 (0)70-332 1551 |
\ gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9 /
------------------------------------------------------------ ---
|
|
|
|
Goto Forum:
Current Time: Tue Jul 22 02:19:24 GMT 2025
Total time taken to generate the page: 0.09919 seconds
|
OpenVZ Forum
Members
Search
Help
Register
Login
Home
