OpenVZ Forum: Support » vzprocps top bugfix for centos5.2 x86-64

Home » General » Support » vzprocps top bugfix for centos5.2 x86-64

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

vzprocps top bugfix for centos5.2 x86-64 [message #32379]

Mon, 04 August 2008 18:04

chaoztc
Messages: 3
Registered: February 2006

Junior Member

procps is very old and has a bug, that even is in commercial virtuozzo present, but only at x86-64 occurs a seg-fault.

problem 1: -fwriteable-strings is no more supported in new gcc compilers.

diff to procps-2.0.11:
--- procps-2.0.11/Makefile_org  2008-08-04 21:39:51.000000000 +0200
+++ procps-2.0.11/Makefile      2008-08-04 21:39:56.000000000 +0200
@@ -170,7 +170,7 @@
        $(strip $(CC) $(CFLAGS) $(W_SHOWFROM) -c $<)
 
 top.o: top.c
-       $(strip $(CC) $(CFLAGS) -fwritable-strings -c $<)
+       $(strip $(CC) $(CFLAGS) -c $<)
 
 skill.o:       skill.c
        $(strip $(CC) $(CFLAGS) -DSYSV -c $<)

problem 2:
description missing in sort, even at virtuozzo.

--- procps-2.0.11-vz.patch_org  2008-08-04 21:42:06.000000000 +0200
+++ procps-2.0.11-vz.patch      2008-08-04 21:42:37.000000000 +0200
@@ -1025,12 +1025,13 @@
  };
  /* corresponding field desciptions */
  char *headers2[] = {
-@@ -152,7 +154,8 @@
+@@ -152,7 +154,9 @@
        "Dirty Pages", "Resident Set Size (kb)", "Sleeping in Function",
        "Process Status", "CPU Time", "Command",
        "Last used CPU (expect this to change regularly)",
 -      "Task Flags (see linux/sched.h)"
 +      "Task Flags (see linux/sched.h)",
++      "CPU number",
 +      "Virtual Environment ID"
  };

with this patches it works also at x86-64 systems.
install src package:
rpm -i vzprocps-2.0.11-6.12.swsoft.src.rpm
patch files
and compile with:
rpmbuild -ba SPECS/vzprocps.spec

[Updated on: Mon, 04 August 2008 18:06]

Report message to a moderator

Re: vzprocps top bugfix for centos5.2 x86-64 [message #32454 is a reply to message #32379]

Sat, 09 August 2008 00:46

khorenko
Messages: 533
Registered: January 2006
Location: Moscow, Russia

Senior Member

Thank you very much, Ingo, we'll fix the description (problem 2).

as for problem 1 - seems that newer procps packages have it already fixed.

Thank you for the report!

--
Konstantin

If your problem is solved - please, report it!
It's even more important than reporting the problem itself...

Report message to a moderator