OpenVZ Forum


Home » Mailing lists » Devel » [PATCH 2/2] signals: replace p->pid == 1 check with a check for task_child_reaper
Re: [PATCH 2/2] signals: replace p->pid == 1 check with a check for task_child_reaper [message #32049 is a reply to message #32044] Thu, 17 July 2008 18:51 Go to previous message
ebiederm is currently offline  ebiederm
Messages: 1354
Registered: February 2006
Senior Member
"Daniel Hokka Zakrisson" <daniel@hozac.com> writes:

> Eric W. Biederman wrote:
>> Daniel Hokka Zakrisson <daniel@hozac.com> writes:
>>
>>> p->pid == 1 is insufficient when there are multiple pid namespaces.
>>> Instead, check whether the task is in the current task's
>>> child reaper's thread group.
>>
>> We should just drop the check for init as it is redundant.

Sorry that was a half truth.  Outside of the context of pid namespaces it is true.

In the context of pid namespaces it is false because we haven't merged the patches
to drop signals from inside the pid namespace on the way to init.

So it is a check that _should_ be redundant.

Eric
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
 
Read Message
Read Message
Read Message
Read Message
Previous Topic: Checkpoint/Restart mini-summit
Next Topic: [PATCH 1/1] signal: Introduce kill_pid_ns_info
Goto Forum:
  


Current Time: Sun Aug 31 13:43:52 GMT 2025

Total time taken to generate the page: 0.14061 seconds