[GIT PATCH] actually check va randomization [message #30936] |
Tue, 10 June 2008 23:51 ![Go to next message Go to next message](/theme/ovz3/images/down.png) |
Dave Hansen
Messages: 240 Registered: October 2005
|
Senior Member |
|
|
Rather than just documenting this in the readme, actually spit
out a warning on it.
You can pull from: git://git.sr71.net/~dave/cryo-forhallyn.git/
-- Dave
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
|
|
|
|
Re: [GIT PATCH] actually check va randomization [message #30986 is a reply to message #30936] |
Wed, 11 June 2008 18:35 ![Go to previous message Go to previous message](/theme/ovz3/images/up.png) ![Go to next message Go to next message](/theme/ovz3/images/down.png) |
Sukadev Bhattiprolu
Messages: 413 Registered: August 2006
|
Senior Member |
|
|
Dave Hansen [dave@linux.vnet.ibm.com] wrote:
| Rather than just documenting this in the readme, actually spit
| out a warning on it.
Why not just bail out ? Its mostly unreliable at that point anyway.
Besides, the warning can get buried in lot of other output.
---
>From 84d005031a8a17bdca62dc541c296a3bea74658c Mon Sep 17 00:00:00 2001
From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Date: Wed, 11 Jun 2008 11:22:17 -0700
Subject: [PATCH] cryo currently requires randomize_va_space to be 0. Fail if it is not.
---
cr.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/cr.c b/cr.c
index db3ada0..217c5e7 100644
--- a/cr.c
+++ b/cr.c
@@ -1464,6 +1464,7 @@ void check_for_va_randomize(void)
return;
fprintf(stderr, "WARNING: %s is set to: %d\n", VA_RANDOM_FILE, enabled);
fprintf(stderr, " Please set to 0 to make cryo more reliable\n");
+ exit(1);
}
void usage(void)
--
1.5.2.5
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
|
|
|
Re: [GIT PATCH] actually check va randomization [message #30988 is a reply to message #30986] |
Wed, 11 June 2008 19:52 ![Go to previous message Go to previous message](/theme/ovz3/images/up.png) |
serue
Messages: 750 Registered: February 2006
|
Senior Member |
|
|
Quoting sukadev@us.ibm.com (sukadev@us.ibm.com):
> Dave Hansen [dave@linux.vnet.ibm.com] wrote:
> | Rather than just documenting this in the readme, actually spit
> | out a warning on it.
>
> Why not just bail out ? Its mostly unreliable at that point anyway.
> Besides, the warning can get buried in lot of other output.
> ---
> >From 84d005031a8a17bdca62dc541c296a3bea74658c Mon Sep 17 00:00:00 2001
> From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
> Date: Wed, 11 Jun 2008 11:22:17 -0700
> Subject: [PATCH] cryo currently requires randomize_va_space to be 0. Fail if it is not.
>
> ---
> cr.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/cr.c b/cr.c
> index db3ada0..217c5e7 100644
> --- a/cr.c
> +++ b/cr.c
> @@ -1464,6 +1464,7 @@ void check_for_va_randomize(void)
> return;
> fprintf(stderr, "WARNING: %s is set to: %d\n", VA_RANDOM_FILE, enabled);
> fprintf(stderr, " Please set to 0 to make cryo more reliable\n");
> + exit(1);
> }
>
> void usage(void)
Oh... Thanks, Suka, I'd just done the same thing using an ERROR().
thanks,
-serge
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
|
|
|