OpenVZ Forum


Home » Mailing lists » Devel » [PATCH 0/3 net-2.6.26] Compilation fixes.
Re: [PATCH 0/3 net-2.6.26] Compilation fixes. [message #28978 is a reply to message #28977] Wed, 02 April 2008 20:56 Go to previous messageGo to previous message
davem is currently offline  davem
Messages: 463
Registered: February 2006
Senior Member
From: "Denis V. Lunev" <den@openvz.org>
Date: Wed, 02 Apr 2008 23:46:19 +0400

> On Wed, 2008-04-02 at 11:42 -0700, David Miller wrote:
> > From: "Denis V. Lunev" <den@openvz.org>
> > Date: Wed, 02 Apr 2008 14:01:14 +0400
> > 
> > > Dave, could you pls conside this addition. This should fix problem
> > > reported by the Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> recently.
> > 
> > Then this invalidates enourmous amounts of CONFIG_NET tests
> > we've put into the headers over the past few days. 
> > 
> > All of them were explicitly to avoid having to provide the
> > init_net symbol when CONFIG_NET is not set.
> 
> OK. do you suggest to insert another CONFIG_NET check into if_pppox
> header or separate fs/compat_ioctl.c into two files:
> - for net ioctls
> - for the rest?

It's probably better to go your route.  That is, unprotect
the init_net extern, and remove the CONFIG_NET's we added
which are no longer necessary.

Could you do such a patch set?  Thanks.
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
 
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Previous Topic: [PATCH][ICMP]: Dst entry leak in icmp_send host re-lookup code (v2).
Next Topic: [PATCH 0/3] IPv6 start/stop problems
Goto Forum:
  


Current Time: Sat Jul 19 22:07:50 GMT 2025

Total time taken to generate the page: 0.07331 seconds