[PATCH] fix spurious EBUSY on memory cgroup removal [message #28606] |
Tue, 25 March 2008 05:47 |
yamamoto
Messages: 97 Registered: July 2007
|
Member |
|
|
[ resending with To: akpm. Andrew, can you include this in -mm tree? ]
hi,
the following patch is to fix spurious EBUSY on cgroup removal.
YAMAMOTO Takashi
call mm_free_cgroup earlier.
otherwise a reference due to lazy mm switching can prevent cgroup removal.
Signed-off-by: YAMAMOTO Takashi <yamamoto@valinux.co.jp>
Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>
---
--- linux-2.6.24-rc8-mm1/kernel/fork.c.BACKUP 2008-01-23 14:43:29.000000000 +0900
+++ linux-2.6.24-rc8-mm1/kernel/fork.c 2008-01-31 17:26:31.000000000 +0900
@@ -393,7 +393,6 @@ void __mmdrop(struct mm_struct *mm)
{
BUG_ON(mm == &init_mm);
mm_free_pgd(mm);
- mm_free_cgroup(mm);
destroy_context(mm);
free_mm(mm);
}
@@ -415,6 +414,7 @@ void mmput(struct mm_struct *mm)
spin_unlock(&mmlist_lock);
}
put_swap_token(mm);
+ mm_free_cgroup(mm);
mmdrop(mm);
}
}
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
|
|
|
|
|
Re: [PATCH] fix spurious EBUSY on memory cgroup removal [message #28609 is a reply to message #28607] |
Tue, 25 March 2008 06:30 |
KAMEZAWA Hiroyuki
Messages: 463 Registered: September 2006
|
Senior Member |
|
|
On Mon, 24 Mar 2008 22:53:09 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:
> On Tue, 25 Mar 2008 14:47:13 +0900 (JST) yamamoto@valinux.co.jp (YAMAMOTO Takashi) wrote:
>
> > [ resending with To: akpm. Andrew, can you include this in -mm tree? ]
>
> Shouldn't it be in 2.6.25?
>
I think this should be.
Thanks,
-Kame
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
|
|
|
Re: [PATCH] fix spurious EBUSY on memory cgroup removal [message #28610 is a reply to message #28609] |
Tue, 25 March 2008 06:28 |
Balbir Singh
Messages: 491 Registered: August 2006
|
Senior Member |
|
|
KAMEZAWA Hiroyuki wrote:
> On Mon, 24 Mar 2008 22:53:09 -0700
> Andrew Morton <akpm@linux-foundation.org> wrote:
>
>> On Tue, 25 Mar 2008 14:47:13 +0900 (JST) yamamoto@valinux.co.jp (YAMAMOTO Takashi) wrote:
>>
>>> [ resending with To: akpm. Andrew, can you include this in -mm tree? ]
>> Shouldn't it be in 2.6.25?
>>
> I think this should be.
>
> Thanks,
> -Kame
Me too
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
|
|
|