OpenVZ Forum


Home » Mailing lists » Devel » [PATCH (resend)] Don't create tunnels with '%' in name.
Re: [PATCH (resend)] Don't create tunnels with '%' in name. [message #27781 is a reply to message #27779] Wed, 27 February 2008 07:51 Go to previous message
davem is currently offline  davem
Messages: 463
Registered: February 2006
Senior Member
From: Pavel Emelyanov <xemul@openvz.org>
Date: Wed, 27 Feb 2008 10:44:33 +0300

> Four tunnel drivers (ip_gre, ipip, ip6_tunnel and sit) can
> receive a pre-defined name for a device from the userspace.
> Since these drivers call the register_netdevice() (rtnl_lock,
> is held), which does _not_ generate the device's name, this 
> name may contain a '%' character.
> 
> Not sure how bad is this to have a device with a '%' in its
> name, but all the other places either use the register_netdev(),
> which call the dev_alloc_name(), or explicitly call the 
> dev_alloc_name() before registering, i.e. do not allow for 
> such names.
> 
> This had to be prior to the commit 34cc7b, but I forgot to
> number the patches and this one got lost, sorry.
> 
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>

Applied, thanks Pavel.

I've already sent a pull request to Linus an hour ago, so
this will get in next time around.
 
Read Message
Read Message
Previous Topic: [PATCH] Control Groups: Add Paul Menage a maintainer
Next Topic: [PATCH] Fix warning in kernel/pid.c
Goto Forum:
  


Current Time: Wed Jul 17 07:40:10 GMT 2024

Total time taken to generate the page: 0.02841 seconds