OpenVZ Forum


Home » Mailing lists » Devel » [PATCH] [NETNS]: Namespace leak in pneigh_lookup.
[PATCH] [NETNS]: Namespace leak in pneigh_lookup. [message #27551] Tue, 19 February 2008 13:12 Go to next message
den is currently offline  den
Messages: 494
Registered: December 2005
Senior Member
release_net is missed on the error path in pneigh_lookup.

Signed-off-by: Denis V. Lunev <den@openvz.org>
---
 net/core/neighbour.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index 7bb6a9a..174e29e 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -507,6 +507,7 @@ struct pneigh_entry * pneigh_lookup(struct neigh_table *tbl,
 	if (tbl->pconstructor && tbl->pconstructor(n)) {
 		if (dev)
 			dev_put(dev);
+		release_net(net);
 		kfree(n);
 		n = NULL;
 		goto out;
-- 
1.5.3.rc5
Re: [PATCH] [NETNS]: Namespace leak in pneigh_lookup. [message #27592 is a reply to message #27551] Wed, 20 February 2008 08:26 Go to previous message
davem is currently offline  davem
Messages: 463
Registered: February 2006
Senior Member
From: "Denis V. Lunev" <den@openvz.org>
Date: Tue, 19 Feb 2008 16:12:38 +0300

> release_net is missed on the error path in pneigh_lookup.
> 
> Signed-off-by: Denis V. Lunev <den@openvz.org>

Applied, thanks a lot.
Previous Topic: [RFC][PATCH 0/7] CGroup API: More structured API for CGroups control files
Next Topic: [PATCH 7/7] cgroup: remove dead code in cgroup_get_rootdir()
Goto Forum:
  


Current Time: Wed Jul 17 21:23:03 GMT 2024

Total time taken to generate the page: 0.02659 seconds