OpenVZ Forum


Home » Mailing lists » Devel » Re: [PATCH 2/3] memcgroup: fix typo in VM_BUG_ON()
[PATCH] memcgroup: remove a useless VM_BUG_ON() [message #27513 is a reply to message #27440] Mon, 18 February 2008 07:34 Go to previous message
Li Zefan is currently offline  Li Zefan
Messages: 90
Registered: February 2008
Member
Remove this VM_BUG_ON(), as Balbir stated:

We used to have a for loop with !list_empty() as a termination condition
and VM_BUG_ON(!pc) is a spill over. With the new loop, VM_BUG_ON(!pc) does not
make sense.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
 mm/memcontrol.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 718acf8..631002d 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -534,7 +534,6 @@ unsigned long mem_cgroup_isolate_pages(unsigned long nr_to_scan,
 		if (scan >= nr_to_scan)
 			break;
 		page = pc->page;
-		VM_BUG_ON(!pc);
 
 		if (unlikely(!PageLRU(page)))
 			continue;
-- 
1.5.4.rc3
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
 
Read Message
Read Message
Read Message
Previous Topic: Re: [PATCH 2/3] memcgroup: fix typo in VM_BUG_ON()
Next Topic: Re: [PATCH] memcgroup: remove a useless VM_BUG_ON()
Goto Forum:
  


Current Time: Fri Oct 10 23:38:56 GMT 2025

Total time taken to generate the page: 0.20766 seconds