OpenVZ Forum


Home » Mailing lists » Devel » [PATCH 3/3] memcgroup: return negative error code in mem_cgroup_create()
[PATCH 3/3] memcgroup: return negative error code in mem_cgroup_create() [message #27504] Mon, 18 February 2008 05:59
Li Zefan is currently offline  Li Zefan
Messages: 90
Registered: February 2008
Member
Cgroup requires the subsystem to return negative error code on
error in the create method.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
---
 mm/memcontrol.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index c2959ee..4aac04c 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -1101,7 +1101,7 @@ mem_cgroup_create(struct cgroup_subsys *ss, struct cgroup *cont)
 		mem = kzalloc(sizeof(struct mem_cgroup), GFP_KERNEL);
 
 	if (mem == NULL)
-		return NULL;
+		return ERR_PTR(-ENOMEM);
 
 	res_counter_init(&mem->res);
 
@@ -1117,7 +1117,7 @@ free_out:
 		free_mem_cgroup_per_zone_info(mem, node);
 	if (cont->parent != NULL)
 		kfree(mem);
-	return NULL;
+	return ERR_PTR(-ENOMEM);
 }
 
 static void mem_cgroup_pre_destroy(struct cgroup_subsys *ss,
-- 
1.5.4.rc3

_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
Previous Topic: [PATCH 2/3] memcgroup: fix typo in VM_BUG_ON()
Next Topic: Re: [PATCH 1/3] memcgroup: fix and update documentation
Goto Forum:
  


Current Time: Mon Jul 28 00:01:04 GMT 2025

Total time taken to generate the page: 0.46409 seconds