OpenVZ Forum


Home » Mailing lists » Devel » Re: [PATCH] memcgroup: remove a useless VM_BUG_ON()
Re: [PATCH] memcgroup: remove a useless VM_BUG_ON() [message #27455] Mon, 18 February 2008 08:47
KAMEZAWA Hiroyuki is currently offline  KAMEZAWA Hiroyuki
Messages: 463
Registered: September 2006
Senior Member
On Mon, 18 Feb 2008 15:34:48 +0800
Li Zefan <lizf@cn.fujitsu.com> wrote:

> Remove this VM_BUG_ON(), as Balbir stated:
> 
> We used to have a for loop with !list_empty() as a termination condition
> and VM_BUG_ON(!pc) is a spill over. With the new loop, VM_BUG_ON(!pc) does not
> make sense.
> 
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> ---
>  mm/memcontrol.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 718acf8..631002d 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -534,7 +534,6 @@ unsigned long mem_cgroup_isolate_pages(unsigned long nr_to_scan,
>  		if (scan >= nr_to_scan)
>  			break;
>  		page = pc->page;
> -		VM_BUG_ON(!pc);
>  
>  		if (unlikely(!PageLRU(page)))
>  			continue;
> -- 
> 1.5.4.rc3
> 
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

Thanks,
-Kame

_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
Previous Topic: Re: [PATCH] memcgroup: remove a useless VM_BUG_ON()
Next Topic: [RFC][PATCH 7/7] CGroup API: Update cpusets to use cgroup structured file API
Goto Forum:
  


Current Time: Tue Aug 19 01:56:00 GMT 2025

Total time taken to generate the page: 0.14827 seconds