Re: Traffic Accounting (patch) [message #2535 is a reply to message #2532] |
Sun, 09 April 2006 06:31   |
dev
Messages: 1693 Registered: September 2005 Location: Moscow
|
Senior Member |

|
|
Julian,
in general it is fine. Some comments:
1. changing existing /proc output is bad usually as can break exisitng users. better create a separate proc file for such things. On the other hand, if you know what you are doing... ))
2. such approach doesn't account trafic through network devices delegated to VPS.
3. on VPS restart counters are reset, so maliscous user can use it somehow, if values are read quite rarely. maybe it is not a problem for many people though.
Thanks!
[Updated on: Sun, 09 April 2006 06:31] Report message to a moderator
|
|
|