[PATCH 2.6.25] [IPV4] Reduce whitespaces in fib_rules.h. [message #25038] |
Thu, 13 December 2007 14:17 |
den
Messages: 494 Registered: December 2005
|
Senior Member |
|
|
There are to many spaces between type and function name in the declaration
of fib rules manipulation routines. Eat them and save a couple of lines.
Signed-off-by: Denis V. Lunev <den@openvz.org>
---
include/net/fib_rules.h | 16 +++++++---------
1 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/include/net/fib_rules.h b/include/net/fib_rules.h
index 2364db1..d20db25 100644
--- a/include/net/fib_rules.h
+++ b/include/net/fib_rules.h
@@ -101,14 +101,12 @@ static inline u32 frh_get_table(struct fib_rule_hdr *frh, struct nlattr **nla)
return frh->table;
}
-extern int fib_rules_register(struct fib_rules_ops *);
-extern int fib_rules_unregister(struct fib_rules_ops *);
-extern void fib_rules_cleanup_ops(struct fib_rules_ops *);
+extern int fib_rules_register(struct fib_rules_ops *);
+extern int fib_rules_unregister(struct fib_rules_ops *);
+extern void fib_rules_cleanup_ops(struct fib_rules_ops *);
-extern int fib_rules_lookup(struct fib_rules_ops *,
- struct flowi *, int flags,
- struct fib_lookup_arg *);
-extern int fib_default_rule_add(struct fib_rules_ops *,
- u32 pref, u32 table,
- u32 flags);
+extern int fib_rules_lookup(struct fib_rules_ops *, struct flowi *, int flags,
+ struct fib_lookup_arg *);
+extern int fib_default_rule_add(struct fib_rules_ops *, u32 pref, u32 table,
+ u32 flags);
#endif
--
1.5.3.rc5
|
|
|
Re: [PATCH 2.6.25] [IPV4] Reduce whitespaces in fib_rules.h. [message #25040 is a reply to message #25038] |
Thu, 13 December 2007 14:47 |
Alexey Dobriyan
Messages: 195 Registered: August 2006
|
Senior Member |
|
|
On Thu, Dec 13, 2007 at 05:18:42PM +0300, Denis V. Lunev wrote:
> There are to many spaces between type and function name in the declaration
> of fib rules manipulation routines. Eat them and save a couple of lines.
If this patch is going in, it would be nice to get rid of "extern" as
well.
Alexey, who once removed all externs from prototypes
and got 4 seconds compilation speedup.
> --- a/include/net/fib_rules.h
> +++ b/include/net/fib_rules.h
> @@ -101,14 +101,12 @@ static inline u32 frh_get_table(struct fib_rule_hdr *frh, struct nlattr **nla)
> return frh->table;
> }
>
> -extern int fib_rules_register(struct fib_rules_ops *);
> -extern int fib_rules_unregister(struct fib_rules_ops *);
> -extern void fib_rules_cleanup_ops(struct fib_rules_ops *);
> +extern int fib_rules_register(struct fib_rules_ops *);
> +extern int fib_rules_unregister(struct fib_rules_ops *);
> +extern void fib_rules_cleanup_ops(struct fib_rules_ops *);
>
> -extern int fib_rules_lookup(struct fib_rules_ops *,
> - struct flowi *, int flags,
> - struct fib_lookup_arg *);
> -extern int fib_default_rule_add(struct fib_rules_ops *,
> - u32 pref, u32 table,
> - u32 flags);
> +extern int fib_rules_lookup(struct fib_rules_ops *, struct flowi *, int flags,
> + struct fib_lookup_arg *);
> +extern int fib_default_rule_add(struct fib_rules_ops *, u32 pref, u32 table,
> + u32 flags);
> #endif
|
|
|
|
|
|
|