OpenVZ Forum


Home » Mailing lists » Devel » [PATCH 2.6.25] netns: network namespace was passed into dev_getbyhwaddr but not used
[PATCH 2.6.25] netns: network namespace was passed into dev_getbyhwaddr but not used [message #24936] Wed, 12 December 2007 11:05 Go to next message
den is currently offline  den
Messages: 494
Registered: December 2005
Senior Member
netns: network namespace was passed into dev_getbyhwaddr but not used

Signed-off-by: Denis V. Lunev <den@openvz.org>
diff --git a/net/core/dev.c b/net/core/dev.c
index 06615df..677f35b 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -675,7 +675,7 @@ struct net_device *dev_getbyhwaddr(struct net *net, unsigned short type, char *h
 
 	ASSERT_RTNL();
 
-	for_each_netdev(&init_net, dev)
+	for_each_netdev(net, dev)
 		if (dev->type == type &&
 		    !memcmp(dev->dev_addr, ha, dev->addr_len))
 			return dev;
Re: [PATCH 2.6.25] netns: network namespace was passed into dev_getbyhwaddr but not used [message #24986 is a reply to message #24936] Wed, 12 December 2007 18:50 Go to previous message
davem is currently offline  davem
Messages: 463
Registered: February 2006
Senior Member
From: "Denis V. Lunev" <den@openvz.org>
Date: Wed, 12 Dec 2007 14:05:17 +0300

> netns: network namespace was passed into dev_getbyhwaddr but not used
> 
> Signed-off-by: Denis V. Lunev <den@openvz.org>

Applied.

Please always put the subsystem name in the headline in
all capitals and surround it with brackets, like this:

[NETNS]: Blah blah blah.

Also treat the description line as a true English sentence, this means
capitalize the first word and put a period at the end of it.  This is
a changelog message for a professional piece of software, not some
"innanet" slang talk on some IRC channel. :-)

I make these edits to every one of your patch submissions and it's
getting tiring, I hoped you would notice this yourself before my
needing to tell you about it explicitly :-)
Previous Topic: kernel thread accounted to a VE
Next Topic: [PATCH] Remove unused define from loopback driver
Goto Forum:
  


Current Time: Sat Jul 05 06:10:25 GMT 2025

Total time taken to generate the page: 0.02151 seconds