OpenVZ Forum


Home » Mailing lists » Devel » [PATCH][VLAN] Lost rtnl_unlock() in vlan_ioctl()
[PATCH][VLAN] Lost rtnl_unlock() in vlan_ioctl() [message #24575] Thu, 06 December 2007 13:52 Go to previous message
Pavel Emelianov is currently offline  Pavel Emelianov
Messages: 1149
Registered: September 2006
Senior Member
The SET_VLAN_NAME_TYPE_CMD command w/o CAP_NET_ADMIN capability
doesn't release the rtnl lock.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>

---

diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
index 6567213..5b18315 100644
--- a/net/8021q/vlan.c
+++ b/net/8021q/vlan.c
@@ -776,7 +776,7 @@ static int vlan_ioctl_handler(struct net *net, void __user *arg)
 	case SET_VLAN_NAME_TYPE_CMD:
 		err = -EPERM;
 		if (!capable(CAP_NET_ADMIN))
-			return -EPERM;
+			break;
 		if ((args.u.name_type >= 0) &&
 		    (args.u.name_type < VLAN_NAME_TYPE_HIGHEST)) {
 			vlan_name_type = args.u.name_type;
 
Read Message
Read Message
Read Message
Read Message
Read Message
Previous Topic: [PATCH] pid: sys_wait... fixes
Next Topic: [PATCH 2.6.25] multiple namespaces in the all dst_ifdown routines
Goto Forum:
  


Current Time: Thu Aug 15 17:57:56 GMT 2024

Total time taken to generate the page: 0.02863 seconds