OpenVZ Forum


Home » Mailing lists » Devel » Re: [patch 1/1] selinux: do not clear f_op when removing entries
Re: [patch 1/1] selinux: do not clear f_op when removing entries [message #23660] Wed, 21 November 2007 14:13
Christoph Hellwig is currently offline  Christoph Hellwig
Messages: 59
Registered: April 2006
Member
On Wed, Nov 21, 2007 at 09:01:36AM -0500, Stephen Smalley wrote:
> Do not clear f_op when removing entries since it isn't safe to do.

If this is still safe for selinux I'm fine with it.  It also gets rid
of one of them few remaining s_files users which is always good.

Btw, after this patch we should be able to kill all places that check
for a non-zero file->f_op because it should never be non-zero.  Of course
we'll need an actual audit first to make sure nothing has been slipping
through.
 
Read Message
Previous Topic: [PATCH 1/4] proc: fix NULL ->i_fop oops
Next Topic: Re: [patch 1/1] selinux: do not clear f_op when removing entries
Goto Forum:
  


Current Time: Fri Oct 18 18:03:16 GMT 2024

Total time taken to generate the page: 0.04927 seconds