OpenVZ Forum


Home » Mailing lists » Devel » [PATCH] proc: remove useless check on symlink removal
[PATCH] proc: remove useless check on symlink removal [message #23342] Thu, 15 November 2007 16:14
Alexey Dobriyan is currently offline  Alexey Dobriyan
Messages: 195
Registered: August 2006
Senior Member
proc symlinks always have valid ->data containing destination of symlink.
No need to check it on removal -- proc_symlink() already done it.

Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
---

 fs/proc/generic.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/proc/generic.c
+++ b/fs/proc/generic.c
@@ -704,7 +704,7 @@ void free_proc_entry(struct proc_dir_entry *de)
 
 	release_inode_number(ino);
 
-	if (S_ISLNK(de->mode) && de->data)
+	if (S_ISLNK(de->mode))
 		kfree(de->data);
 	kfree(de);
 }
 
Read Message
Previous Topic: [PATCH] proc: prototypes redux
Next Topic: [PATCH] proc: remove useless checks in proc_register()
Goto Forum:
  


Current Time: Thu Aug 21 04:08:32 GMT 2025

Total time taken to generate the page: 0.05967 seconds