OpenVZ Forum: Devel » [PATCH 1/2] iptables 32bit compat layer

Home » Mailing lists » Devel » [PATCH 1/2] iptables 32bit compat layer

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH] iptables 32bit compat layer [message #2329 is a reply to message #2327]

Wed, 29 March 2006 12:32

Patrick McHardy
Messages: 107
Registered: March 2006

Senior Member

Dmitry Mishin wrote:
> On Wednesday 29 March 2006 13:28, Patrick McHardy wrote:
>
>>>diff --git a/net/compat.c b/net/compat.c
>>>index 13177a1..6a7028e 100644
>>>--- a/net/compat.c
>>>+++ b/net/compat.c
>>>@@ -476,8 +476,7 @@ asmlinkage long compat_sys_setsockopt(in
>>> int err;
>>> struct socket *sock;
>>>
>>>- /* SO_SET_REPLACE seems to be the same in all levels */
>>>- if (optname == IPT_SO_SET_REPLACE)
>>>+ if (level == SOL_IPV6 && optname == IPT_SO_SET_REPLACE)
>>> return do_netfilter_replace(fd, level, optname,
>>> optval, optlen);
>>
>>I don't understand the reason for this change. If its not a mistake,
>>it would make more sense to check for IP6T_SO_SET_REPLACE I guess ..
>
> IP6T_SO_SET_REPLACE == IPT_SO_SET_REPLACE == XT_SO_SET_REPLACE.
> Rename will require respective #include directive rename, so, I just leave
> this as it is. BTW, I'll make respective patch for IPV6 in the near future
> and this hunk will be removed at all.

I know, but SOL_IPV6 implies IP6T_* - but please don't bother sending
a new patch for this :) So the point of the change is to exclude IPv6
from the compat layer because its not implemented yet?

Report message to a moderator

[Message index]

		[PATCH 1/2] iptables 32bit compat layer By: Mishin Dmitry on Mon, 20 February 2006 08:10
		Re: [PATCH 1/2] iptables 32bit compat layer By: davem on Mon, 20 February 2006 08:31
		Re: [PATCH 1/2] iptables 32bit compat layer By: Arnd Bergmann on Mon, 20 February 2006 15:55
		Re: Re: [PATCH 1/2] iptables 32bit compat layer By: dim on Tue, 21 February 2006 09:04
		Re: Re: [PATCH 1/2] iptables 32bit compat layer By: Arnd Bergmann on Tue, 21 February 2006 11:56
		{get\|set}sockopt compat layer By: Mishin Dmitry on Tue, 07 March 2006 14:07
		Re: {get\|set}sockopt compat layer By: Arnd Bergmann on Tue, 07 March 2006 15:05
		Re: {get\|set}sockopt compat layer By: Mishin Dmitry on Thu, 09 March 2006 10:23
		Re: {get\|set}sockopt compat layer By: davem on Thu, 09 March 2006 23:29
		[PATCH] {get\|set}sockopt compatibility layer By: Mishin Dmitry on Fri, 10 March 2006 11:21
		Re: [PATCH] {get\|set}sockopt compatibility layer By: davem on Fri, 10 March 2006 11:34
		Re: [PATCH 1/2] iptables 32bit compat layer By: Andi Kleen on Mon, 20 February 2006 21:23
		Re: Re: [PATCH 1/2] iptables 32bit compat layer By: dim on Tue, 21 February 2006 09:24
		[PATCH] iptables 32bit compat layer By: Mishin Dmitry on Thu, 23 March 2006 10:24
		Re: [PATCH] iptables 32bit compat layer By: Patrick McHardy on Wed, 29 March 2006 09:28
		Re: [PATCH] iptables 32bit compat layer By: Mishin Dmitry on Wed, 29 March 2006 11:36
		Re: [PATCH] iptables 32bit compat layer By: Patrick McHardy on Wed, 29 March 2006 12:32
		Re: [PATCH] iptables 32bit compat layer By: Mishin Dmitry on Wed, 29 March 2006 12:38
		Re: [PATCH] iptables 32bit compat layer By: Patrick McHardy on Wed, 29 March 2006 12:47
		Re: [PATCH] iptables 32bit compat layer By: davem on Wed, 29 March 2006 21:53
		Re: [PATCH] iptables 32bit compat layer By: Patrick McHardy on Wed, 29 March 2006 23:01

Previous Topic:	[RFC] Virtualization patches for IPC/UTS. 2nd step
Next Topic:	Re: Linux-VServer and OpenVZ for Debian

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Tue Nov 04 12:36:12 GMT 2025

Total time taken to generate the page: 0.11111 seconds