OpenVZ Forum


Home » Mailing lists » Devel » [PATCH 2/4] Add missed tunnel64_err handler
Re: [PATCH 2/4] Add missed tunnel64_err handler [message #23051 is a reply to message #23010] Sun, 11 November 2007 05:48 Go to previous message
davem is currently offline  davem
Messages: 463
Registered: February 2006
Senior Member
From: Pavel Emelyanov <xemul@openvz.org>
Date: Fri, 09 Nov 2007 16:14:12 +0300

> The tunnel64_protocol uses the tunnel4_protocol's err_handler and
> thus calls the tunnel4_protocol's handlers.
> 
> This is not very good, as in case of (icmp) error the wrong error
> handlers will be called (e.g. ipip ones instead of sit) and this
> won't be noticed at all, because the error is not reported.
> 
> Was that made deliberately and I miss something?
> 
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>

This definitely was doing the wrong thing for the SIT
case, for example.  So this looks legitimate to me.

Patch applied, thanks!
 
Read Message
Read Message
Previous Topic: [PATCH 1/4] Un-define the IPTUNNEL_XMIT() macro
Next Topic: [PATCH 3/4] Cleanup the xfrm4_tunnel_(un)register
Goto Forum:
  


Current Time: Tue Sep 09 13:38:54 GMT 2025

Total time taken to generate the page: 0.07221 seconds