OpenVZ Forum


Home » Mailing lists » Devel » [PATCH] Fix memory leak in cleanup_ipv6_mibs()
[PATCH] Fix memory leak in cleanup_ipv6_mibs() [message #21889] Wed, 17 October 2007 14:04 Go to next message
Pavel Emelianov is currently offline  Pavel Emelianov
Messages: 1149
Registered: September 2006
Senior Member
The icmpv6msg mib statistics is not freed.

This is almost not critical for current kernel, since ipv6
module is unloadable, but this can happen on load error and 
will happen every time we stop the network namespace (when 
we have one, of course).

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>

---

diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c
index bc92938..1b1caf3 100644
--- a/net/ipv6/af_inet6.c
+++ b/net/ipv6/af_inet6.c
@@ -747,6 +747,7 @@ static void cleanup_ipv6_mibs(void)
 {
 	snmp_mib_free((void **)ipv6_statistics);
 	snmp_mib_free((void **)icmpv6_statistics);
+	snmp_mib_free((void **)icmpv6msg_statistics);
 	snmp_mib_free((void **)udp_stats_in6);
 	snmp_mib_free((void **)udplite_stats_in6);
 }
Re: [PATCH] Fix memory leak in cleanup_ipv6_mibs() [message #21898 is a reply to message #21889] Wed, 17 October 2007 16:23 Go to previous messageGo to next message
David Stevens is currently offline  David Stevens
Messages: 2
Registered: October 2007
Junior Member
Acked-by: David L Stevens <dlstevens@us.ibm.com>
 
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
> 
> ---
> 
> diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c
> index bc92938..1b1caf3 100644
> --- a/net/ipv6/af_inet6.c
> +++ b/net/ipv6/af_inet6.c
> @@ -747,6 +747,7 @@ static void cleanup_ipv6_mibs(void)
>  {
>     snmp_mib_free((void **)ipv6_statistics);
>     snmp_mib_free((void **)icmpv6_statistics);
> +   snmp_mib_free((void **)icmpv6msg_statistics);
>     snmp_mib_free((void **)udp_stats_in6);
>     snmp_mib_free((void **)udplite_stats_in6);
>  }
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Fix memory leak in cleanup_ipv6_mibs() [message #21928 is a reply to message #21898] Thu, 18 October 2007 02:30 Go to previous message
davem is currently offline  davem
Messages: 463
Registered: February 2006
Senior Member
From: David Stevens <dlstevens@us.ibm.com>
Date: Wed, 17 Oct 2007 09:23:39 -0700

> Acked-by: David L Stevens <dlstevens@us.ibm.com>
>  
> > Signed-off-by: Pavel Emelyanov <xemul@openvz.org>

Applied, thanks.
Previous Topic: [PATCH 1/1] namespaces: introduce sys_hijack (v6)
Next Topic: [PATCH 0/7] Next step in consolidating the IP fragment management
Goto Forum:
  


Current Time: Wed Sep 18 05:23:42 GMT 2024

Total time taken to generate the page: 0.04860 seconds