OpenVZ Forum


Home » Mailing lists » Devel » [NETNS45][patch 0/1] remove udp rover
[NETNS45][patch 0/1] remove udp rover [message #20283] Fri, 14 September 2007 15:48 Go to next message
Daniel Lezcano is currently offline  Daniel Lezcano
Messages: 417
Registered: June 2006
Senior Member
just a little cleanup

-- 
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
[NETNS45][patch 1/1] remove udp rover port [message #20284 is a reply to message #20283] Fri, 14 September 2007 15:48 Go to previous messageGo to next message
Daniel Lezcano is currently offline  Daniel Lezcano
Messages: 417
Registered: June 2006
Senior Member
From: Daniel Lezcano <dlezcano@fr.ibm.com>

in net-2.6.24, the algorithm which choose a port is changed. The rover
port is no longer a global static variable, it is computed dynamically
with net_random, each time a get_port call is done.

So no need to have it in the network namespace

Signed-off-by: Daniel Lezcano <dlezcano@fr.ibm.com>
---
 include/net/net_namespace.h |    3 ---
 1 file changed, 3 deletions(-)

Index: linux-2.6-netns/include/net/net_namespace.h
===================================================================
--- linux-2.6-netns.orig/include/net/net_namespace.h
+++ linux-2.6-netns/include/net/net_namespace.h
@@ -138,9 +138,6 @@ struct net {
 	atomic_t		ip_frag_mem;
 	struct timer_list	ipfrag_secret_timer;
 
-	/* udp.c */
-	int			udp_port_rover;
-
 	/* iptable_filter.c */
 	struct xt_table		*ip_packet_filter;
 };

-- 
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
Re: [NETNS45][patch 1/1] remove udp rover port [message #20285 is a reply to message #20284] Fri, 14 September 2007 16:04 Go to previous message
ebiederm is currently offline  ebiederm
Messages: 1354
Registered: February 2006
Senior Member
dlezcano@fr.ibm.com writes:

> From: Daniel Lezcano <dlezcano@fr.ibm.com>
>
> in net-2.6.24, the algorithm which choose a port is changed. The rover
> port is no longer a global static variable, it is computed dynamically
> with net_random, each time a get_port call is done.
>
> So no need to have it in the network namespace

Good catch.  Thanks.

Eric
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
Previous Topic: Network namespace status
Next Topic: Re: [PATCH] Hookup group-scheduler with task container infrastructure
Goto Forum:
  


Current Time: Thu Sep 12 20:40:03 GMT 2024

Total time taken to generate the page: 0.05146 seconds