OpenVZ Forum


Home » Mailing lists » Devel » Re: [PATCH 1/1] Dynamically allocate the loopback device
Re: [PATCH 1/1] Dynamically allocate the loopback device [message #19781 is a reply to message #19758] Fri, 24 August 2007 21:24 Go to previous messageGo to previous message
dlunev is currently offline  dlunev
Messages: 14
Registered: August 2007
Junior Member
no, and this is important. Loopback is initialized in fs_initcall which
is called sufficiently before module_init.

I have checked the code and do not see initialization order mistakes
right now. But, from now on, maintainer should pay attention for this
unfortunate consequence :(

Regards,
    Den

Stephen Hemminger wrote:
> On Fri, 24 Aug 2007 19:55:47 +0400
> "Denis V. Lunev" <dlunev@gmail.com> wrote:
> 
>> dlezcano@fr.ibm.com wrote:
>>> From: Daniel Lezcano <dlezcano@fr.ibm.com>
>>>
>>> Doing this makes loopback.c a better example of how to do a
>>> simple network device, and it removes the special case
>>> single static allocation of a struct net_device, hopefully
>>> making maintenance easier.
>>>
>>> Applies against net-2.6.24
>>>
>>> Tested on i386, x86_64
>>> Compiled on ia64, sparc
>> I think that a small note, that initialization order is changed will be
>> good to record. After this, loopback MUST be allocated before any other
>> networking subsystem initialization. And this is an important change.
>>
>> Regards,
>>     Den
> 
> Yes, this code would break when other drivers are directly linked
> in. 
> _______________________________________________
> Containers mailing list
> Containers@lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/containers
> 
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
 
Read Message
Read Message
Read Message
Previous Topic: [PATCH] Use helpers to obtain task pid in printks (arch code)
Next Topic: Fwd: [LTP] Containers Testcases Plan
Goto Forum:
  


Current Time: Fri Oct 10 16:41:30 GMT 2025

Total time taken to generate the page: 0.10908 seconds