OpenVZ Forum: Devel » [PATCH] ext3: ext3_symlink should use GFP

Home » Mailing lists » Devel » [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside (ver. 3)

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside (ver. 3) [message #1963 is a reply to message #1962]

Fri, 10 March 2006 08:52

dev
Messages: 1693
Registered: September 2005
Location: Moscow

Senior Member

>>Andrew,
>>
>>Fixed both comments from Al Viro (thanks, Al):
>>- should have a separate helper
>>- should pass 0 instead of GFP_KERNEL in page_symlink()
>
>
>>
>>+ page = find_or_create_page(mapping, 0,
>>+ mapping_gfp_mask(mapping) | gfp_mask);
>
>
>
>
> this does not work; GFP_NOFS has a bit *LESS* than GFP_KERNEL, not a bit
> more. As such a | operation isn't going to be useful....
>
> (So I think that while Al's intention was good, the implication of it
> isn't ;)
Oh no... Had to sleep well today... :/
Al, are you agree with the original patch then?
I don't think it is a good idea to introduce AND mask instead :)

Thanks,
Kirill

Report message to a moderator

[Message index]

		[PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside (ver. 3) By: Kirill Korotaev on Fri, 10 March 2006 08:41
		Re: [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside (ver. 3) By: Arjan van de Ven on Fri, 10 March 2006 08:46
		Re: [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside (ver. 3) By: dev on Fri, 10 March 2006 08:52
		Re: [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside (ver. 3) By: Andrew Morton on Fri, 10 March 2006 08:56
		Re: [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside (ver. 3) By: dev on Fri, 10 March 2006 09:06
		Re: [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside (ver. 3) By: Al Viro on Fri, 10 March 2006 08:59
		Re: [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside (ver. 3) By: Arjan van de Ven on Fri, 10 March 2006 09:40

Previous Topic:	[PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside
Next Topic:	[PATCH 1/2] virtualized ipt_REDIRECT

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Thu Dec 04 07:22:17 GMT 2025

Total time taken to generate the page: 0.68850 seconds