OpenVZ Forum


Home » Mailing lists » Devel » [patch 06/22] ext3: remove extra IS_RDONLY() check
[patch 06/22] ext3: remove extra IS_RDONLY() check [message #18806] Thu, 07 June 2007 15:25
Cedric Le Goater is currently offline  Cedric Le Goater
Messages: 443
Registered: February 2006
Senior Member
From: Dave Hansen <hansendc@us.ibm.com>

ext3_change_inode_journal_flag() is only called from one
location: ext3_ioctl(EXT3_IOC_SETFLAGS).  That ioctl
case already has a IS_RDONLY() call in it so this one
is superfluous.

Signed-off-by: Dave Hansen <hansendc@us.ibm.com>
---

---
 fs/ext3/inode.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: 2.6.22-rc4-mm2-robindmount/fs/ext3/inode.c
===================================================================
--- 2.6.22-rc4-mm2-robindmount.orig/fs/ext3/inode.c
+++ 2.6.22-rc4-mm2-robindmount/fs/ext3/inode.c
@@ -3235,7 +3235,7 @@ int ext3_change_inode_journal_flag(struc
 	 */
 
 	journal = EXT3_JOURNAL(inode);
-	if (is_journal_aborted(journal) || IS_RDONLY(inode))
+	if (is_journal_aborted(journal))
 		return -EROFS;
 
 	journal_lock_updates(journal);

-- 
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
 
Read Message
Previous Topic: [patch 05/22] elevate write count files are open()ed
Next Topic: [patch 07/22] ext4: remove extra IS_RDONLY() check
Goto Forum:
  


Current Time: Fri Aug 22 06:49:03 GMT 2025

Total time taken to generate the page: 0.05706 seconds