OpenVZ Forum


Home » Mailing lists » Devel » [RFC][PATCH 0/16] Enable cloning of pid namespace
Re: [RFC][PATCH 14/16] Introduce proc_mnt for pid_ns [message #18642 is a reply to message #18623] Thu, 24 May 2007 16:51 Go to previous messageGo to previous message
Dave Hansen is currently offline  Dave Hansen
Messages: 240
Registered: October 2005
Senior Member
On Thu, 2007-05-24 at 14:15 +0400, Pavel Emelianov wrote:
> 
> >       s->s_flags |= MS_NODIRATIME | MS_NOSUID | MS_NOEXEC;
> > @@ -466,6 +467,7 @@ int proc_fill_super(struct super_block *
> >       s->s_magic = PROC_SUPER_MAGIC;
> >       s->s_op = &proc_sops;
> >       s->s_time_gran = 1;
> > +     s->s_fs_info = pid_ns;
> 
> One more thing I've just noticed - you don't get the namespace
> here so after all the tasks die and namespace is freed we
> have a proc mount pointing to freed namespace... 

Yep, missed reference count.  Thanks for catching this!

-- Dave

_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
 
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Previous Topic: [PATCH 0/13] Pid namespaces (OpenVZ view)
Next Topic: [PATCH 05/10] Containers(V10): Add container_clone() interface
Goto Forum:
  


Current Time: Sat Sep 06 21:30:58 GMT 2025

Total time taken to generate the page: 0.24875 seconds