OpenVZ Forum: Devel » [PATCH 0/59] Cleanup sysctl

Home » Mailing lists » Devel » [PATCH 0/59] Cleanup sysctl

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH 45/59] sysctl: C99 convert ctl_tables in drivers/parport/procfs.c [message #17226 is a reply to message #17194]

Tue, 16 January 2007 22:15

Ingo Oeser
Messages: 4
Registered: January 2007

Junior Member

Hi Eric,

On Tuesday, 16. January 2007 17:39, Eric W. Biederman wrote:
> diff --git a/drivers/parport/procfs.c b/drivers/parport/procfs.c
> index 2e744a2..5337789 100644
> --- a/drivers/parport/procfs.c
> +++ b/drivers/parport/procfs.c
> @@ -263,50 +263,118 @@ struct parport_sysctl_table {
> +		{
> +			.ctl_name	= DEV_PARPORT_BASE_ADDR,
> +			.procname	= "base-addr",
> +			.data		= NULL,
> +			.maxlen		= 0,
> +			.mode		= 0444,
> +			.proc_handler	= &do_hardware_base_addr
> +		},

No need to initialize to zero or NULL. Just list any variable, which is NOT zero or NULL.

> +		{
> +			.ctl_name	= DEV_PARPORT_AUTOPROBE + 1,
> +			.procname	= "autoprobe0",
> +			.data		= NULL,
> +			.maxlen		= 0,
> +			.maxlen		= 0444,
> +			.proc_handler	=  &do_autoprobe
> +		},

Typo here? .mode = 0444 makes mor sense.

Regards

Ingo Oeser
_______________________________________________
Containers mailing list
Containers@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/containers

Report message to a moderator

[Message index]

		[PATCH 0/59] Cleanup sysctl By: ebiederm on Tue, 16 January 2007 16:33
		[PATCH 1/59] sysctl x25: Remove unnecessary insert_at_head from register_sysctl_table. By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 2/59] sysctl: Move CTL_SUNRPC to sysctl.h where it belongs By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 3/59] sysctl: sunrpc Remove unnecessary insert_at_head flag By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 4/59] sysctl: sunrpc Don't unnecessarily set ctl_table->de By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 5/59] sysctl: rose remove unnecessary insert_at_head flag By: ebiederm on Tue, 16 January 2007 16:39
		Re: [PATCH 5/59] sysctl: rose remove unnecessary insert_at_head flag By: Ralf Baechle on Tue, 16 January 2007 17:36
		[PATCH 6/59] sysctl: netrom remove unnecessary insert_at_head flag By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 7/59] sysctl: llc remove unnecessary insert_at_head flag By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 8/59] sysctl: ipx remove unnecessary insert_at_head flag By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 9/59] sysctl: decnet remove unnecessary insert_at_head flag By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 10/59] sysctl: dccp remove unnecessary insert_at_head flag By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 11/59] sysctl: ax25 remove unnecessary insert_at_head flag By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 12/59] sysctl: atalk remove unnecessary insert_at_head flag By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 13/59] sysctl: xfs remove unnecessary insert_at_head flag By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 14/59] sysctl: C99 convert xfs ctl_tables By: ebiederm on Tue, 16 January 2007 16:39
		Re: [PATCH 14/59] sysctl: C99 convert xfs ctl_tables By: dev on Wed, 17 January 2007 17:01
		[PATCH 15/59] sysctl: scsi remove unnecessary insert_at_head flag By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 16/59] sysctl: md Remove unnecessary insert_at_head flag By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 17/59] sysctl: mac_hid remove unnecessary insert_at_head flag By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 18/59] sysctl: ipmi remove unnecessary insert_at_head flag By: ebiederm on Tue, 16 January 2007 16:39
		Re: [PATCH 18/59] sysctl: ipmi remove unnecessary insert_at_head flag By: Benjamin Herrenschmid on Wed, 17 January 2007 03:14
		[PATCH 19/59] sysctl: cdrom remove unnecessary insert_at_head flag By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 20/59] sysctl: cdrom Don't set de->owner By: ebiederm on Tue, 16 January 2007 16:39
		Re: [PATCH 20/59] sysctl: cdrom Don't set de->owner By: James Bottomley on Tue, 16 January 2007 18:19
		[PATCH 21/59] sysctl: Move CTL_PM into sysctl.h where it belongs. By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 22/59] sysctl: frv pm remove unnecessary insert_at_head flag By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 23/59] sysctl: Move CTL_FRV into sysctl.h where it belongs By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 24/59] sysctl: frv remove unnecessary insert_at_head flag By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 25/59] sysctl: C99 convert arch/frv/kernel/pm.c By: ebiederm on Tue, 16 January 2007 16:39
		Re: [PATCH 25/59] sysctl: C99 convert arch/frv/kernel/pm.c By: dev on Wed, 17 January 2007 17:14
		Re: [PATCH 25/59] sysctl: C99 convert arch/frv/kernel/pm.c By: Herbert Poetzl on Mon, 22 January 2007 22:21
		Re: [PATCH 25/59] sysctl: C99 convert arch/frv/kernel/pm.c By: David Howells on Wed, 24 January 2007 09:00
		[PATCH 26/59] sysctl: C99 convert arch/frv/kernel/sysctl.c By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 27/59] sysctl: sn Remove sysctl ABI BREAKAGE By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 28/59] sysctl: C99 Convert arch/ia64/sn/kernel/xpc_main.c By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 29/59] sysctl: C99 convert arch/ia64/kernel/perfmon and remove ABI breakage By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 30/59] sysctl: mips/au1000 Remove sys_sysctl support By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 31/59] sysctl: C99 convert the ctl_tables in arch/mips/au1000/common/power.c By: ebiederm on Tue, 16 January 2007 16:39
		Re: [PATCH 31/59] sysctl: C99 convert the ctl_tables in arch/mips/au1000/common/power.c By: Ingo Oeser on Tue, 16 January 2007 22:20
		[PATCH 32/59] sysctl: C99 convert arch/mips/lasat/sysctl.c and remove ABI breakage. By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 33/59] sysctl: s390 move sysctl definitions to sysctl.h By: ebiederm on Tue, 16 January 2007 16:39
		Re: [PATCH 33/59] sysctl: s390 move sysctl definitions to sysctl.h By: dev on Wed, 17 January 2007 17:23
		[PATCH 34/59] sysctl: s390 Remove unnecessary use of insert_at_head By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 35/59] sysctl: C99 convert ctl_tables in arch/powerpc/kernel/idle.c By: ebiederm on Tue, 16 January 2007 16:39
		Re: [PATCH 35/59] sysctl: C99 convert ctl_tables in arch/powerpc/kernel/idle.c By: Benjamin Herrenschmid on Wed, 17 January 2007 03:16
		[PATCH 36/59] sysctl: C99 convert ctl_tables entries in arch/ppc/kernel/ppc_htab.c By: ebiederm on Tue, 16 January 2007 16:39
		Re: [PATCH 36/59] sysctl: C99 convert ctl_tables entries in arch/ppc/kernel/ppc_htab.c By: Benjamin Herrenschmid on Wed, 17 January 2007 03:16
		[PATCH 37/59] sysctl: C99 convert arch/sh64/kernel/traps.c and remove ABI breakage. By: ebiederm on Tue, 16 January 2007 16:39
		Re: [PATCH 37/59] sysctl: C99 convert arch/sh64/kernel/traps.c and remove ABI breakage. By: Paul Mundt on Tue, 16 January 2007 22:07
		[PATCH 38/59] sysctl: x86_64 Remove unnecessary use of insert_at_head By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 39/59] sysctl: C99 convert ctl_tables in arch/x86_64/ia32/ia32_binfmt.c By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 40/59] sysctl: C99 convert ctl_tables in arch/x86_64/kernel/vsyscall.c By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 41/59] sysctl: C99 convert ctl_tables in arch/x86_64/mm/init.c By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 42/59] sysctl: Remove sys_sysctl support from the hpet timer driver. By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 43/59] sysctl: Remove sys_sysctl support from drivers/char/rtc.c By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 44/59] sysctl: Register the sysctl number used by the arlan driver. By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 45/59] sysctl: C99 convert ctl_tables in drivers/parport/procfs.c By: ebiederm on Tue, 16 January 2007 16:39
		Re: [PATCH 45/59] sysctl: C99 convert ctl_tables in drivers/parport/procfs.c By: ebiederm on Tue, 16 January 2007 23:00
		Re: [PATCH 45/59] sysctl: C99 convert ctl_tables in drivers/parport/procfs.c By: Ingo Oeser on Tue, 16 January 2007 22:15
		[PATCH 46/59] sysctl: C99 convert coda ctl_tables and remove binary sysctls. By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 47/59] sysctl: C99 convert ctl_tables in NTFS and remove sys_sysctl support By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 48/59] sysctl: Register the ocfs2 sysctl numbers By: ebiederm on Tue, 16 January 2007 16:39
		Re: [PATCH 48/59] sysctl: Register the ocfs2 sysctl numbers By: Mark Fasheh on Tue, 16 January 2007 20:37
		[PATCH 49/59] sysctl: Move init_irq_proc into init/main where it belongs By: ebiederm on Tue, 16 January 2007 16:39
		Re: [PATCH 49/59] sysctl: Move init_irq_proc into init/main where it belongs By: Andrew Morton on Sat, 27 January 2007 10:51
		[PATCH 50/59] sysctl: Move utsname sysctls to their own file By: ebiederm on Tue, 16 January 2007 16:39
		Re: [PATCH 50/59] sysctl: Move utsname sysctls to their own file By: ebiederm on Wed, 17 January 2007 19:31
		Re: [PATCH 50/59] sysctl: Move utsname sysctls to their own file By: Herbert Poetzl on Mon, 22 January 2007 22:24
		Re: [PATCH 50/59] sysctl: Move utsname sysctls to their own file By: dev on Wed, 17 January 2007 17:41
		[PATCH 51/59] sysctl: Move SYSV IPC sysctls to their own file By: ebiederm on Tue, 16 January 2007 16:39
		Re: [PATCH 51/59] sysctl: Move SYSV IPC sysctls to their own file By: dev on Wed, 17 January 2007 17:44
		[PATCH 52/59] sysctl: Create sys/fs/binfmt_misc as an ordinary sysctl entry By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 53/59] sysctl: Remove support for CTL_ANY By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 54/59] sysctl: Remove support for directory strategy routines. By: ebiederm on Tue, 16 January 2007 16:39
		[PATCH 55/59] sysctl: Remove insert_at_head from register_sysctl By: ebiederm on Tue, 16 January 2007 16:40
		[PATCH 56/59] sysctl: factor out sysctl_head_next from do_sysctl By: ebiederm on Tue, 16 January 2007 16:40
		[PATCH 57/59] sysctl: allow sysctl_perm to be called from outside of sysctl.c By: ebiederm on Tue, 16 January 2007 16:40
		[PATCH 58/59] sysctl: Reimplement the sysctl proc support By: ebiederm on Tue, 16 January 2007 16:40
		[PATCH 59/59] sysctl: Remove the proc_dir_entry member for the sysctl tables. By: ebiederm on Tue, 16 January 2007 16:40
		Re: [PATCH 0/59] Cleanup sysctl By: hpa on Tue, 16 January 2007 18:35
		Re: [PATCH 0/59] Cleanup sysctl By: ebiederm on Tue, 16 January 2007 18:54
		Re: [PATCH 0/59] Cleanup sysctl By: hpa on Tue, 16 January 2007 18:58
		Re: [PATCH 0/59] Cleanup sysctl By: ebiederm on Tue, 16 January 2007 19:03
		Re: [PATCH 0/59] Cleanup sysctl By: hpa on Tue, 16 January 2007 19:15
		Re: [PATCH 0/59] Cleanup sysctl By: ebiederm on Tue, 16 January 2007 19:30
		Re: [PATCH 0/59] Cleanup sysctl By: David Howells on Tue, 16 January 2007 20:02
		Re: [PATCH 0/59] Cleanup sysctl By: ebiederm on Wed, 17 January 2007 19:02
		Re: [PATCH 0/59] Cleanup sysctl By: Martin Schwidefsky on Wed, 17 January 2007 12:10
		Re: [PATCH 0/59] Cleanup sysctl By: Andi Kleen on Wed, 17 January 2007 04:21
		Re: [PATCH 0/59] Cleanup sysctl By: dev on Wed, 17 January 2007 18:10

Previous Topic:	gentoo baselayout 1.13 openvz modifications
Next Topic:	[PATCH] :EXT[3, 4] jbd layer function called instead of fs specific one

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Mon Jul 21 15:04:08 GMT 2025

Total time taken to generate the page: 0.14978 seconds