Home » Mailing lists » Devel » [PATCH 0/59] Cleanup sysctl
[PATCH 59/59] sysctl: Remove the proc_dir_entry member for the sysctl tables. [message #17208 is a reply to message #17149] |
Tue, 16 January 2007 16:40   |
ebiederm
Messages: 1354 Registered: February 2006
|
Senior Member |
|
|
From: Eric W. Biederman <ebiederm@xmission.com> - unquoted
It isn't needed anymore, all of the users are gone, and all of the
ctl_table initializers have been converted to use explicit names
of the fields they are initializing.
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---
include/linux/sysctl.h | 1 -
net/decnet/dn_dev.c | 5 -----
net/ipv4/devinet.c | 5 -----
net/ipv6/addrconf.c | 5 -----
4 files changed, 0 insertions(+), 16 deletions(-)
diff --git a/include/linux/sysctl.h b/include/linux/sysctl.h
index 20c23b5..8c2fab5 100644
--- a/include/linux/sysctl.h
+++ b/include/linux/sysctl.h
@@ -1025,7 +1025,6 @@ struct ctl_table
ctl_table *child;
proc_handler *proc_handler; /* Callback for text formatting */
ctl_handler *strategy; /* Callback function for all r/w */
- struct proc_dir_entry *de; /* /proc control block */
void *extra1;
void *extra2;
};
diff --git a/net/decnet/dn_dev.c b/net/decnet/dn_dev.c
index baaa02e..324eb47 100644
--- a/net/decnet/dn_dev.c
+++ b/net/decnet/dn_dev.c
@@ -261,7 +261,6 @@ static void dn_dev_sysctl_register(struct net_device *dev, struct dn_dev_parms *
for(i = 0; i < ARRAY_SIZE(t->dn_dev_vars) - 1; i++) {
long offset = (long)t->dn_dev_vars[i].data;
t->dn_dev_vars[i].data = ((char *)parms) + offset;
- t->dn_dev_vars[i].de = NULL;
}
if (dev) {
@@ -273,13 +272,9 @@ static void dn_dev_sysctl_register(struct net_device *dev, struct dn_dev_parms *
}
t->dn_dev_dev[0].child = t->dn_dev_vars;
- t->dn_dev_dev[0].de = NULL;
t->dn_dev_conf_dir[0].child = t->dn_dev_dev;
- t->dn_dev_conf_dir[0].de = NULL;
t->dn_dev_proto_dir[0].child = t->dn_dev_conf_dir;
- t->dn_dev_proto_dir[0].de = NULL;
t->dn_dev_root_dir[0].child = t->dn_dev_proto_dir;
- t->dn_dev_root_dir[0].de = NULL;
t->dn_dev_vars[0].extra1 = (void *)dev;
t->sysctl_header = register_sysctl_table(t->dn_dev_root_dir);
diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
index b731a0c..8cfcc78 100644
--- a/net/ipv4/devinet.c
+++ b/net/ipv4/devinet.c
@@ -1573,7 +1573,6 @@ static void devinet_sysctl_register(struct in_device *in_dev,
return;
for (i = 0; i < ARRAY_SIZE(t->devinet_vars) - 1; i++) {
t->devinet_vars[i].data += (char *)p - (char *)&ipv4_devconf;
- t->devinet_vars[i].de = NULL;
}
if (dev) {
@@ -1595,13 +1594,9 @@ static void devinet_sysctl_register(struct in_device *in_dev,
t->devinet_dev[0].procname = dev_name;
t->devinet_dev[0].child = t->devinet_vars;
- t->devinet_dev[0].de = NULL;
t->devinet_conf_dir[0].child = t->devinet_dev;
- t->devinet_conf_dir[0].de = NULL;
t->devinet_proto_dir[0].child = t->devinet_conf_dir;
- t->devinet_proto_dir[0].de = NULL;
t->devinet_root_dir[0].child = t->devinet_proto_dir;
- t->devinet_root_dir[0].de = NULL;
t->sysctl_header = register_sysctl_table(t->devinet_root_dir);
if (!t->sysctl_header)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 791aaba..6aded83 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -3973,7 +3973,6 @@ static void addrconf_sysctl_register(struct inet6_dev *idev, struct ipv6_devconf
return;
for (i=0; t->addrconf_vars[i].data; i++) {
t->addrconf_vars[i].data += (char*)p - (char*)&ipv6_devconf;
- t->addrconf_vars[i].de = NULL;
t->addrconf_vars[i].extra1 = idev; /* embedded; no ref */
}
if (dev) {
@@ -3996,13 +3995,9 @@ static void addrconf_sysctl_register(struct inet6_dev *idev, struct ipv6_devconf
t->addrconf_dev[0].procname = dev_name;
t->addrconf_dev[0].child = t->addrconf_vars;
- t->addrconf_dev[0].de = NULL;
t->addrconf_conf_dir[0].child = t->addrconf_dev;
- t->addrconf_conf_dir[0].de = NULL;
t->addrconf_proto_dir[0].child = t->addrconf_conf_dir;
- t->addrconf_proto_dir[0].de = NULL;
t->addrconf_root_dir[0].child = t->addrconf_proto_dir;
- t->addrconf_root_dir[0].de = NULL;
t->sysctl_header = register_sysctl_table(t->addrconf_root_dir);
if (t->sysctl_header == NULL)
--
1.4.4.1.g278f
_______________________________________________
Containers mailing list
Containers@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/containers
|
|
|
 |
|
[PATCH 0/59] Cleanup sysctl
By: ebiederm on Tue, 16 January 2007 16:33
|
 |
|
[PATCH 1/59] sysctl x25: Remove unnecessary insert_at_head from register_sysctl_table.
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 2/59] sysctl: Move CTL_SUNRPC to sysctl.h where it belongs
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 3/59] sysctl: sunrpc Remove unnecessary insert_at_head flag
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 4/59] sysctl: sunrpc Don't unnecessarily set ctl_table->de
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 5/59] sysctl: rose remove unnecessary insert_at_head flag
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
Re: [PATCH 5/59] sysctl: rose remove unnecessary insert_at_head flag
|
 |
|
[PATCH 6/59] sysctl: netrom remove unnecessary insert_at_head flag
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 7/59] sysctl: llc remove unnecessary insert_at_head flag
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 8/59] sysctl: ipx remove unnecessary insert_at_head flag
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 9/59] sysctl: decnet remove unnecessary insert_at_head flag
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 10/59] sysctl: dccp remove unnecessary insert_at_head flag
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 11/59] sysctl: ax25 remove unnecessary insert_at_head flag
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 12/59] sysctl: atalk remove unnecessary insert_at_head flag
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 13/59] sysctl: xfs remove unnecessary insert_at_head flag
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 14/59] sysctl: C99 convert xfs ctl_tables
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
Re: [PATCH 14/59] sysctl: C99 convert xfs ctl_tables
By: dev on Wed, 17 January 2007 17:01
|
 |
|
[PATCH 15/59] sysctl: scsi remove unnecessary insert_at_head flag
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 16/59] sysctl: md Remove unnecessary insert_at_head flag
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 17/59] sysctl: mac_hid remove unnecessary insert_at_head flag
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 18/59] sysctl: ipmi remove unnecessary insert_at_head flag
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
Re: [PATCH 18/59] sysctl: ipmi remove unnecessary insert_at_head flag
|
 |
|
[PATCH 19/59] sysctl: cdrom remove unnecessary insert_at_head flag
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 20/59] sysctl: cdrom Don't set de->owner
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
Re: [PATCH 20/59] sysctl: cdrom Don't set de->owner
|
 |
|
[PATCH 21/59] sysctl: Move CTL_PM into sysctl.h where it belongs.
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 22/59] sysctl: frv pm remove unnecessary insert_at_head flag
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 23/59] sysctl: Move CTL_FRV into sysctl.h where it belongs
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 24/59] sysctl: frv remove unnecessary insert_at_head flag
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 25/59] sysctl: C99 convert arch/frv/kernel/pm.c
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
Re: [PATCH 25/59] sysctl: C99 convert arch/frv/kernel/pm.c
By: dev on Wed, 17 January 2007 17:14
|
 |
|
Re: [PATCH 25/59] sysctl: C99 convert arch/frv/kernel/pm.c
|
 |
|
Re: [PATCH 25/59] sysctl: C99 convert arch/frv/kernel/pm.c
|
 |
|
[PATCH 26/59] sysctl: C99 convert arch/frv/kernel/sysctl.c
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 27/59] sysctl: sn Remove sysctl ABI BREAKAGE
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 28/59] sysctl: C99 Convert arch/ia64/sn/kernel/xpc_main.c
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 29/59] sysctl: C99 convert arch/ia64/kernel/perfmon and remove ABI breakage
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 30/59] sysctl: mips/au1000 Remove sys_sysctl support
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 31/59] sysctl: C99 convert the ctl_tables in arch/mips/au1000/common/power.c
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
Re: [PATCH 31/59] sysctl: C99 convert the ctl_tables in arch/mips/au1000/common/power.c
|
 |
|
[PATCH 32/59] sysctl: C99 convert arch/mips/lasat/sysctl.c and remove ABI breakage.
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 33/59] sysctl: s390 move sysctl definitions to sysctl.h
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
Re: [PATCH 33/59] sysctl: s390 move sysctl definitions to sysctl.h
By: dev on Wed, 17 January 2007 17:23
|
 |
|
[PATCH 34/59] sysctl: s390 Remove unnecessary use of insert_at_head
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 35/59] sysctl: C99 convert ctl_tables in arch/powerpc/kernel/idle.c
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
Re: [PATCH 35/59] sysctl: C99 convert ctl_tables in arch/powerpc/kernel/idle.c
|
 |
|
[PATCH 36/59] sysctl: C99 convert ctl_tables entries in arch/ppc/kernel/ppc_htab.c
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
Re: [PATCH 36/59] sysctl: C99 convert ctl_tables entries in arch/ppc/kernel/ppc_htab.c
|
 |
|
[PATCH 37/59] sysctl: C99 convert arch/sh64/kernel/traps.c and remove ABI breakage.
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
Re: [PATCH 37/59] sysctl: C99 convert arch/sh64/kernel/traps.c and remove ABI breakage.
|
 |
|
[PATCH 38/59] sysctl: x86_64 Remove unnecessary use of insert_at_head
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 39/59] sysctl: C99 convert ctl_tables in arch/x86_64/ia32/ia32_binfmt.c
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 40/59] sysctl: C99 convert ctl_tables in arch/x86_64/kernel/vsyscall.c
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 41/59] sysctl: C99 convert ctl_tables in arch/x86_64/mm/init.c
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 42/59] sysctl: Remove sys_sysctl support from the hpet timer driver.
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 43/59] sysctl: Remove sys_sysctl support from drivers/char/rtc.c
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 44/59] sysctl: Register the sysctl number used by the arlan driver.
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 45/59] sysctl: C99 convert ctl_tables in drivers/parport/procfs.c
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
Re: [PATCH 45/59] sysctl: C99 convert ctl_tables in drivers/parport/procfs.c
By: ebiederm on Tue, 16 January 2007 23:00
|
 |
|
Re: [PATCH 45/59] sysctl: C99 convert ctl_tables in drivers/parport/procfs.c
|
 |
|
[PATCH 46/59] sysctl: C99 convert coda ctl_tables and remove binary sysctls.
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 47/59] sysctl: C99 convert ctl_tables in NTFS and remove sys_sysctl support
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 48/59] sysctl: Register the ocfs2 sysctl numbers
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
Re: [PATCH 48/59] sysctl: Register the ocfs2 sysctl numbers
|
 |
|
[PATCH 49/59] sysctl: Move init_irq_proc into init/main where it belongs
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
Re: [PATCH 49/59] sysctl: Move init_irq_proc into init/main where it belongs
|
 |
|
[PATCH 50/59] sysctl: Move utsname sysctls to their own file
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
Re: [PATCH 50/59] sysctl: Move utsname sysctls to their own file
By: ebiederm on Wed, 17 January 2007 19:31
|
 |
|
Re: [PATCH 50/59] sysctl: Move utsname sysctls to their own file
|
 |
|
Re: [PATCH 50/59] sysctl: Move utsname sysctls to their own file
By: dev on Wed, 17 January 2007 17:41
|
 |
|
[PATCH 51/59] sysctl: Move SYSV IPC sysctls to their own file
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
Re: [PATCH 51/59] sysctl: Move SYSV IPC sysctls to their own file
By: dev on Wed, 17 January 2007 17:44
|
 |
|
[PATCH 52/59] sysctl: Create sys/fs/binfmt_misc as an ordinary sysctl entry
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 53/59] sysctl: Remove support for CTL_ANY
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 54/59] sysctl: Remove support for directory strategy routines.
By: ebiederm on Tue, 16 January 2007 16:39
|
 |
|
[PATCH 55/59] sysctl: Remove insert_at_head from register_sysctl
By: ebiederm on Tue, 16 January 2007 16:40
|
 |
|
[PATCH 56/59] sysctl: factor out sysctl_head_next from do_sysctl
By: ebiederm on Tue, 16 January 2007 16:40
|
 |
|
[PATCH 57/59] sysctl: allow sysctl_perm to be called from outside of sysctl.c
By: ebiederm on Tue, 16 January 2007 16:40
|
 |
|
[PATCH 58/59] sysctl: Reimplement the sysctl proc support
By: ebiederm on Tue, 16 January 2007 16:40
|
 |
|
[PATCH 59/59] sysctl: Remove the proc_dir_entry member for the sysctl tables.
By: ebiederm on Tue, 16 January 2007 16:40
|
 |
|
Re: [PATCH 0/59] Cleanup sysctl
By: hpa on Tue, 16 January 2007 18:35
|
 |
|
Re: [PATCH 0/59] Cleanup sysctl
By: ebiederm on Tue, 16 January 2007 18:54
|
 |
|
Re: [PATCH 0/59] Cleanup sysctl
By: hpa on Tue, 16 January 2007 18:58
|
 |
|
Re: [PATCH 0/59] Cleanup sysctl
By: ebiederm on Tue, 16 January 2007 19:03
|
 |
|
Re: [PATCH 0/59] Cleanup sysctl
By: hpa on Tue, 16 January 2007 19:15
|
 |
|
Re: [PATCH 0/59] Cleanup sysctl
By: ebiederm on Tue, 16 January 2007 19:30
|
 |
|
Re: [PATCH 0/59] Cleanup sysctl
|
 |
|
Re: [PATCH 0/59] Cleanup sysctl
By: ebiederm on Wed, 17 January 2007 19:02
|
 |
|
Re: [PATCH 0/59] Cleanup sysctl
|
 |
|
Re: [PATCH 0/59] Cleanup sysctl
|
 |
|
Re: [PATCH 0/59] Cleanup sysctl
By: dev on Wed, 17 January 2007 18:10
|
Goto Forum:
Current Time: Thu Sep 18 21:01:08 GMT 2025
Total time taken to generate the page: 0.05915 seconds
|