On Mon, Dec 11, 2006 at 02:30:03PM -0800, Dave Hansen wrote:
> 
> 
> We're moving a big chunk of the burden of keeping people from
> writing to r/o filesystems from the superblock into the
> vfsmount.  This requires that we consult the superblock's
> vfsmounts when things like remounts occur.
> 
> So, introduce a list of vfsmounts hanging off the superblock.
> We'll use this in a bit.

I don't think this is a good idea at all.  We should do the same
as for noatime and have both a MNT_RDONLY and MS_RDONLY flag,
aswell as two writecounts.  And even if you disagree with that we
should reorder this patch aswell as those related to it to the
end of the series so the uncontroversial stuff can go in first.
_______________________________________________
Containers mailing list
Containers@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/containers

On Tue, Dec 12, 2006 at 10:33:14AM +0000, Christoph Hellwig wrote:
> On Mon, Dec 11, 2006 at 02:30:03PM -0800, Dave Hansen wrote:
> > 
> > 
> > We're moving a big chunk of the burden of keeping people from
> > writing to r/o filesystems from the superblock into the
> > vfsmount.  This requires that we consult the superblock's
> > vfsmounts when things like remounts occur.
> > 
> > So, introduce a list of vfsmounts hanging off the superblock.
> > We'll use this in a bit.
> 
> I don't think this is a good idea at all.  We should do the same
> as for noatime and have both a MNT_RDONLY and MS_RDONLY flag,
> aswell as two writecounts. 

yes, definitely

best,
Herbert

> And even if you disagree with that we
> should reorder this patch aswell as those related to it to the
> end of the series so the uncontroversial stuff can go in first.
> _______________________________________________
> Containers mailing list
> Containers@lists.osdl.org
> https://lists.osdl.org/mailman/listinfo/containers
_______________________________________________
Containers mailing list
Containers@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/containers