OpenVZ Forum


Home » Mailing lists » Devel » [RFC][PATCH] Add child reaper to struct pspace
Re: [RFC][PATCH] Add child reaper to struct pspace [message #16611 is a reply to message #16594] Thu, 07 September 2006 13:01 Go to previous messageGo to previous message
Cedric Le Goater is currently offline  Cedric Le Goater
Messages: 443
Registered: February 2006
Senior Member
Kirill Korotaev wrote:
> Sukadev Bhattiprolu wrote:
> 
> [...skip...]
> 
>> @@ -857,7 +858,7 @@ fastcall NORET_TYPE void do_exit(long co
>>  		panic("Aiee, killing interrupt handler!");
>>  	if (unlikely(!tsk->pid))
>>  		panic("Attempted to kill the idle task!");
>> -	if (unlikely(tsk == child_reaper))
>> +	if (unlikely(tsk == tsk->pspace->child_reaper))
>>  		panic("Attempted to kill init!");
> this panic is wrong here.
> 
> My HO is that termination of init task
> should terminate all the other tasks in pspace.

yes this should be done, in the complete patchset.

> Otherwise you have too select some one else to be child_reaper
> and actually there is no good choice here as no one except init
> is going to wait() for children.

serge pointed that out also :

http://lists.osdl.org/pipermail/containers/2006-September/000158.html

> p.s. can you enumerate these patches please?
> since I failed to find where  struct pspace was introduced...
> imho in previous patch set? was that patch set already commited to -mm?

yes it is in -mm.

C.
_______________________________________________
Containers mailing list
Containers@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/containers
 
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Previous Topic: Re: Re: [RFC][PATCH] Rename pspace to pid_namespace
Next Topic: Re: [RFC][PATCH 1/2] add user namespace [try #2]
Goto Forum:
  


Current Time: Fri Oct 10 16:40:59 GMT 2025

Total time taken to generate the page: 0.22927 seconds