OpenVZ Forum


Home » Mailing lists » Devel » [PATCH] Freeing alive inet6 address
[PATCH] Freeing alive inet6 address [message #16462] Fri, 07 September 2007 10:21 Go to next message
den is currently offline  den
Messages: 494
Registered: December 2005
Senior Member
From: Denis V. Lunev <den@openvz.org>

addrconf_dad_failure calls addrconf_dad_stop which takes referenced address
and drops the count. So, in6_ifa_put perrformed at out: is extra. This
results in message: "Freeing alive inet6 address" and not released dst entries.

Signed-off-by: Denis V. Lunev <den@openvz.org>
Signed-off-by: Alexey Dobriyan <adobriyan@openvz.org>

--- ./net/ipv6/ndisc.c.ipv6dad	2007-09-03 16:54:32.000000000 +0400
+++ ./net/ipv6/ndisc.c	2007-09-07 13:34:30.000000000 +0400
@@ -736,7 +736,7 @@ static void ndisc_recv_ns(struct sk_buff
 				 * so fail our DAD process
 				 */
 				addrconf_dad_failure(ifp);
-				goto out;
+				return;
 			} else {
 				/*
 				 * This is not a dad solicitation.
Re: [PATCH] Freeing alive inet6 address [message #20041 is a reply to message #16462] Tue, 11 September 2007 09:08 Go to previous message
davem is currently offline  davem
Messages: 463
Registered: February 2006
Senior Member
From: "Denis V. Lunev" <den@openvz.org>
Date: Fri, 7 Sep 2007 14:21:18 +0400

> From: Denis V. Lunev <den@openvz.org>
> 
> addrconf_dad_failure calls addrconf_dad_stop which takes referenced address
> and drops the count. So, in6_ifa_put perrformed at out: is extra. This
> results in message: "Freeing alive inet6 address" and not released dst entries.
> 
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> Signed-off-by: Alexey Dobriyan <adobriyan@openvz.org>

I've seen this bug myself just a week before heading to
Europe for conferences and intended to look into it.

Thanks a lot for fixing this, patch applied.
Previous Topic: [PATCH 3/3] Signal semantics for pid namespaces
Next Topic: Couple of rpm requests, 2.6.22
Goto Forum:
  


Current Time: Thu Aug 07 06:57:55 GMT 2025

Total time taken to generate the page: 1.28195 seconds