OpenVZ Forum


Home » Mailing lists » Devel » Tweak /proc/ipmi removal
Tweak /proc/ipmi removal [message #15528] Fri, 03 August 2007 13:30
Alexey Dobriyan is currently offline  Alexey Dobriyan
Messages: 195
Registered: August 2006
Senior Member
Driver does
	proc_mkdir("ipmi", NULL);
but
	remove_proc_entry(proc_ipmi_root->name, &proc_root);

This is OK and working if only slightly inconsistent.
Also changing proc_root to NULL will help OpenVZ which has
multiple proc roots and, as we now know, requires matching parents in
such cases.

Please, apply.

Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
---

 drivers/char/ipmi/ipmi_msghandler.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -4136,7 +4136,7 @@ static __exit void cleanup_ipmi(void)
 	del_timer_sync(&ipmi_timer);
 
 #ifdef CONFIG_PROC_FS
-	remove_proc_entry(proc_ipmi_root->name, &proc_root);
+	remove_proc_entry(proc_ipmi_root->name, NULL);
 #endif /* CONFIG_PROC_FS */
 
 	driver_unregister(&ipmidriver);
Previous Topic: Re: [2.6.22] negative time jump
Next Topic: Re: [RFC, PATCH] handle the multi-threaded init's exit() properly
Goto Forum:
  


Current Time: Fri Aug 01 15:53:16 GMT 2025

Total time taken to generate the page: 0.34570 seconds