OpenVZ Forum: Devel » [PATCH] Remove CTL

Home » Mailing lists » Devel » [PATCH] Remove CTL_UNNUMBERED

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH] Remove CTL_UNNUMBERED [message #15318 is a reply to message #15315]

Thu, 26 July 2007 17:24

ebiederm
Messages: 1354
Registered: February 2006

Senior Member

Alexey Dobriyan <adobriyan@sw.ru> writes:

> CTL_UNNUMBERED is unneeded, because it expands to
>
> .ctl_name = 0
>
> The same effect can be achieved by skipping .ctl_name initialization,
> saving one line per sysctl.
>
> Update docs and headers telling people to not add CTL_ numbers and
> giving example.
>
> This is probably all we can do to stop the flow of new CTL_ numbers,
> because most of sysctls are copy-pasted. CTL_UNNUMBERED doesn't solve
> this problem at all.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>

Nack. Not unless you update the documentation and explanations
properly.

The important part is that we stop assigning binary numbers. You
are removing part of the description of why we can not assign bianry
numbers and how that is important.

CTL_UNNUMBERED may be an irritant to you but as for actually using the
code I have look and it is about 6 of 1 half dozen of the other.

Eric

Report message to a moderator

[Message index]

		[PATCH] Remove CTL_UNNUMBERED By: Alexey Dobriyan on Thu, 26 July 2007 16:45
		Re: [PATCH] Remove CTL_UNNUMBERED By: ebiederm on Thu, 26 July 2007 17:24
		Re: [PATCH] Remove CTL_UNNUMBERED By: Alexey Dobriyan on Fri, 27 July 2007 14:52
		[PATCH 2/2] sysctl: remove CTL_UNNUMBERED By: Alexey Dobriyan on Mon, 06 August 2007 12:45
		Re: [PATCH 2/2] sysctl: remove CTL_UNNUMBERED By: ebiederm on Thu, 09 August 2007 19:44
		[PATCH 1/3] sysctl core: Stop using the unnecessary ctl_table typedef By: ebiederm on Thu, 09 August 2007 19:50
		[PATCH 2/3] sysctl: Factor out sysctl_data. By: ebiederm on Thu, 09 August 2007 19:52
		[PATCH 3/3] sysctl: Error on bad sysctl tables By: ebiederm on Thu, 09 August 2007 20:09
		[PATCH 01/10] sysctl: Update sysctl_check_table By: ebiederm on Fri, 10 August 2007 00:49
		[PATCH 02/10] sysct mqueue: Remove the binary sysctl numbers By: ebiederm on Fri, 10 August 2007 00:51
		[PATCH 03/10] sysctl: Remove binary sysctl support where it clearly doesn't work. By: ebiederm on Fri, 10 August 2007 00:53
		[PATCH 04/10] sysctl: Fix neighbour table sysctls. By: ebiederm on Fri, 10 August 2007 00:56
		Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls. By: davem on Fri, 10 August 2007 01:49
		Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls. By: yoshfuji on Fri, 10 August 2007 02:14
		Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls. By: Andrew Morton on Fri, 10 August 2007 01:55
		Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls. By: ebiederm on Fri, 10 August 2007 02:12
		Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls. By: yoshfuji on Fri, 10 August 2007 01:47
		Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls. By: yoshfuji on Fri, 10 August 2007 02:21
		Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls. By: ebiederm on Fri, 10 August 2007 02:23
		Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls. By: yoshfuji on Fri, 10 August 2007 02:28
		Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls. By: ebiederm on Fri, 10 August 2007 02:35
		Re: [PATCH 3/3] sysctl: Error on bad sysctl tables By: yoshfuji on Fri, 10 August 2007 02:01
		Re: [PATCH 3/3] sysctl: Error on bad sysctl tables By: ebiederm on Fri, 10 August 2007 02:15
		Re: [PATCH 3/3] sysctl: Error on bad sysctl tables By: ebiederm on Fri, 10 August 2007 02:18

Previous Topic:	[RFC][PATCH] Make access to taks's nsproxy liter
Next Topic:	[PATCH] Allow signalling container-init

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Wed Nov 26 19:12:59 GMT 2025

Total time taken to generate the page: 0.16035 seconds