OpenVZ Forum


Home » Mailing lists » Devel » [PATCH] possible deadlock in tulip driver
[PATCH] possible deadlock in tulip driver [message #15246] Tue, 24 July 2007 07:49 Go to previous message
den is currently offline  den
Messages: 494
Registered: December 2005
Senior Member
Calling flush_scheduled_work() may deadlock if called under rtnl_lock
(from dev->stop) as linkwatch_event() may be on the workqueue and it will try
to get the rtnl_lock

Signed-off-by: Denis V. Lunev <den@openvz.org>
---

tulip_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--- ./drivers/net/tulip/tulip_core.c.tulip 2007-07-16 12:54:29.000000000 +0400
+++ ./drivers/net/tulip/tulip_core.c 2007-07-23 19:06:24.000000000 +0400
@@ -726,8 +726,6 @@ static void tulip_down (struct net_devic
void __iomem *ioaddr = tp->base_addr;
unsigned long flags;

- flush_scheduled_work();
-
del_timer_sync (&tp->timer);
#ifdef CONFIG_TULIP_NAPI
del_timer_sync (&tp->oom_timer);
@@ -1788,6 +1786,8 @@ static void __devexit tulip_remove_one (
if (!dev)
return;

+ flush_scheduled_work();
+
tp = netdev_priv(dev);
unregister_netdev(dev);
pci_free_consistent (pdev,
 
Read Message
Read Message
Read Message
Previous Topic: Re: [PATCH 2/4] sysfs: Implement sysfs manged shadow directory support.
Next Topic: Re: [PATCH 2/4] sysfs: Implement sysfs manged shadow directory support.
Goto Forum:
  


Current Time: Thu Jul 24 19:30:18 GMT 2025

Total time taken to generate the page: 0.24599 seconds