OpenVZ Forum: Devel » [PATCH 00/10] Task Containers(V11): Introduction

Home » Mailing lists » Devel » [PATCH 00/10] Task Containers(V11): Introduction

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH 02/10] Task Containers(V11): Add tasks file interface [message #15201 is a reply to message #15192]

Fri, 20 July 2007 20:20

James Morris
Messages: 10
Registered: March 2006

Junior Member

On Fri, 20 Jul 2007, menage@google.com wrote:

> +/*
> + * Attach task with pid 'pid' to container 'cont'. Call with
> + * container_mutex, may take task_lock of task
> + */
> +static int attach_task_by_pid(struct container *cont, char *pidbuf)
> +{
> + pid_t pid;
> + struct task_struct *tsk;
> + int ret;
> +
> + if (sscanf(pidbuf, "%d", &pid) != 1)
> + return -EIO;
> +
> + if (pid) {
> + rcu_read_lock();
> + tsk = find_task_by_pid(pid);
> + if (!tsk || tsk->flags & PF_EXITING) {
> + rcu_read_unlock();
> + return -ESRCH;
> + }
> + get_task_struct(tsk);
> + rcu_read_unlock();
> +
> + if ((current->euid) && (current->euid != tsk->uid)
> + && (current->euid != tsk->suid)) {
> + put_task_struct(tsk);
> + return -EACCES;

I wonder if we should allow CAP_SYS_ADMIN to do this, too.

--
James Morris
<jmorris@namei.org>

Report message to a moderator

[Message index]

		[PATCH 00/10] Task Containers(V11): Introduction By: Paul Menage on Fri, 20 July 2007 18:31
		[PATCH 02/10] Task Containers(V11): Add tasks file interface By: Paul Menage on Fri, 20 July 2007 18:31
		Re: [PATCH 02/10] Task Containers(V11): Add tasks file interface By: James Morris on Fri, 20 July 2007 20:20
		Re: [PATCH 02/10] Task Containers(V11): Add tasks file interface By: Paul Menage on Fri, 20 July 2007 21:25
		[PATCH 04/10] Task Containers(V11): Add container_clone() interface. By: Paul Menage on Fri, 20 July 2007 18:31
		[PATCH 06/10] Task Containers(V11): Shared container subsystem group arrays By: Paul Menage on Fri, 20 July 2007 18:31
		[PATCH 05/10] Task Containers(V11): Add procfs interface By: Paul Menage on Fri, 20 July 2007 18:31
		[PATCH 10/10] Task Containers(V11): Simple task container debug info subsystem By: Paul Menage on Fri, 20 July 2007 18:32
		[PATCH 01/10] Task Containers(V11): Basic task container framework By: Paul Menage on Fri, 20 July 2007 18:31
		Re: [PATCH 01/10] Task Containers(V11): Basic task container framework By: yamamoto on Fri, 27 July 2007 05:31
		Re: [PATCH 01/10] Task Containers(V11): Basic task container framework By: Paul Menage on Sun, 29 July 2007 17:03
		Re: [PATCH 01/10] Task Containers(V11): Basic task container framework By: yamamoto on Mon, 30 July 2007 04:00
		[PATCH 07/10] Task Containers(V11): Automatic userspace notification of idle containers By: Paul Menage on Fri, 20 July 2007 18:31
		Re: [PATCH 07/10] Task Containers(V11): Automatic userspace notification of idle containers By: serue on Mon, 23 July 2007 17:41

Previous Topic:	[Fwd: [2.6.22] negative time jump]
Next Topic:	[PATCH] Add CTL_PROC back

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sat Aug 29 10:53:02 GMT 2026

Total time taken to generate the page: 0.67231 seconds