OpenVZ Forum


Home » Mailing lists » Devel » [PATCH] cfq: async queue allocation per priority
Re: [PATCH] cfq: async queue allocation per priority [message #15094 is a reply to message #15089] Wed, 18 July 2007 18:51 Go to previous messageGo to previous message
Jens Axboe is currently offline  Jens Axboe
Messages: 30
Registered: October 2006
Member
On Wed, Jul 18 2007, Vasily Tarasov wrote:
> Jens, I think the last patch, that makes queues allocation per priority,
> has a problem.
>
> If we have two processes with different ioprio_class, but the same
> ioprio_data, their async requests will fall into the same queue. I guess
> such behavior is not expected, because it's not right to put real-time
> requests and best-effort requests in the same queue.
>
> The attached patch fixes the problem by introducing additional *cfqq
> fields on cfqd, pointing to per-(class,priority) async queues.

Ugh yes. I'm pretty tempted just to reinstate the cfqq hash again, it
used to be a clean up but now the it's not stacking up so well.

--
Jens Axboe
 
Read Message
Read Message
Read Message
Read Message
Previous Topic: [PATCH] Cleanup elevator_ops->trim function
Next Topic: [PATCH] Add kernel/notifier.c
Goto Forum:
  


Current Time: Fri Sep 19 19:56:12 GMT 2025

Total time taken to generate the page: 0.08807 seconds