OpenVZ Forum: Devel » jbd lost fix?

Home » Mailing lists » Devel » jbd lost fix?

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

jbd lost fix? [message #14564]

Mon, 02 July 2007 14:16

Kirill Korotaev
Messages: 137
Registered: January 2006

Senior Member

Jan,

it looks like the following fix:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6 .git;a=commitdiff;h=43c3e6f5abdf6acac9b90c86bf03f995bf7d3d92

was lost after resurrecting of the spliced checkpointing list in this patch:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6 .git ;a=commitdiff;h=78ce89c92bc6eaf5933b5664bff64253a7103bd7;hp= cdaad343b561cdeb38b0578bb038

Can you please confirm that?

Thanks,
Kirill

Report message to a moderator

Re: jbd lost fix? [message #14750 is a reply to message #14564]

Mon, 09 July 2007 14:24

dev
Messages: 1693
Registered: September 2005
Location: Moscow

Senior Member

Jan Kara wrote:
> Hello,
>
> On Mon 02-07-07 18:16:09, Kirill Korotaev wrote:
>
>>it looks like the following fix:
>> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6 .git;a=commitdiff;h=43c3e6f5abdf6acac9b90c86bf03f995bf7d3d92
>>
>>was lost after resurrecting of the spliced checkpointing list in this patch:
>> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6 .git ;a=commitdiff;h=78ce89c92bc6eaf5933b5664bff64253a7103bd7;hp= cdaad343b561cdeb38b0578bb038
>>
>>Can you please confirm that?
>
> Sorry for a bit late reply but I was on holiday for a week. Yes, it seems
> like that fix got lost. At least 2.6.22-rc5 still has a wrong test on line
> 890 in commit.c. Thanks for notification, I'll resend it.
> BTW: How have you found this out?

One of OpenVZ users had an oops at journal_clean_one_cp_list+0x32/0x70
http://bugzilla.openvz.org/show_bug.cgi?id=605

which led us to the lost fix.
Since the patch existed before I didn't dare to resend it from OVZ name :)

Thanks,
Kirill

Report message to a moderator

Re: jbd lost fix? [message #14933 is a reply to message #14564]

Mon, 09 July 2007 13:00

Jan Kara
Messages: 13
Registered: July 2007

Junior Member

Hello,

On Mon 02-07-07 18:16:09, Kirill Korotaev wrote:
> it looks like the following fix:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6 .git;a=commitdiff;h=43c3e6f5abdf6acac9b90c86bf03f995bf7d3d92
>
> was lost after resurrecting of the spliced checkpointing list in this patch:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6 .git ;a=commitdiff;h=78ce89c92bc6eaf5933b5664bff64253a7103bd7;hp= cdaad343b561cdeb38b0578bb038
>
> Can you please confirm that?
Sorry for a bit late reply but I was on holiday for a week. Yes, it seems
like that fix got lost. At least 2.6.22-rc5 still has a wrong test on line
890 in commit.c. Thanks for notification, I'll resend it.
BTW: How have you found this out?

Honza
--
Jan Kara <jack@suse.cz>
SuSE CR Labs

Report message to a moderator

Previous Topic:	Re: netns summary (was Re: containers development plans)
Next Topic:	L2 network namespaces + macvlan performances

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Thu Nov 13 17:46:50 GMT 2025

Total time taken to generate the page: 0.31750 seconds