OpenVZ Forum: Devel » filemap.c: interesting check around zero_length

Home » Mailing lists » Devel » filemap.c: interesting check around zero_length_segment:

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

filemap.c: interesting check around zero_length_segment: [message #14481]

Fri, 29 June 2007 07:56

Alexey Dobriyan
Messages: 195
Registered: August 2006

Senior Member

Adding -W -Wno-stupid-warnings results in the following warning:

mm/filemap.c: In function 'generic_file_buffered_write':
mm/filemap.c:2179: warning: comparison of unsigned expression >= 0 is always true

if (likely(copied >= 0)) {
if (!status)
status = copied;

Branch is always taken since "copied" is size_t.

Such code doesn't exist in -mm, but is this something to worry about for
current and older kernels?

Report message to a moderator