OpenVZ Forum: Devel » [PATCH] x86_64: arch_pick_mmap

Home » Mailing lists » Devel » [PATCH] x86_64: arch_pick_mmap_layout() fixlet

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

[PATCH] x86_64: arch_pick_mmap_layout() fixlet [message #14445]

Thu, 28 June 2007 08:45

Alexey Dobriyan
Messages: 195
Registered: August 2006

Senior Member

sparse now warns about
arch/x86_64/mm/mmap.c:15:3: warning: returning void-valued expression

Generated code looks correct: there is jump to the end of
arch_pick_mmap_layout() after ia32_pick_mmap_layout(), but this should be fixed
regardless.

Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
---

arch/x86_64/mm/mmap.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

--- a/arch/x86_64/mm/mmap.c
+++ b/arch/x86_64/mm/mmap.c
@@ -11,8 +11,10 @@
void arch_pick_mmap_layout(struct mm_struct *mm)
{
#ifdef CONFIG_IA32_EMULATION
- if (current_thread_info()->flags & _TIF_IA32)
- return ia32_pick_mmap_layout(mm);
+ if (current_thread_info()->flags & _TIF_IA32) {
+ ia32_pick_mmap_layout(mm);
+ return;
+ }
#endif
mm->mmap_base = TASK_UNMAPPED_BASE;
if (current->flags & PF_RANDOMIZE) {

Report message to a moderator