OpenVZ Forum


Home » Mailing lists » Devel » [PATCH -mm 1/2] i386: semi-rewrite of PTRACE_PEEKUSR, PTRACE_POKEUSR
Re: [PATCH -mm 1/2] i386: semi-rewrite of PTRACE_PEEKUSR, PTRACE_POKEUSR [message #14261 is a reply to message #14255] Wed, 20 June 2007 15:53 Go to previous message
Andi Kleen is currently offline  Andi Kleen
Messages: 33
Registered: February 2006
Member
On Wednesday 20 June 2007 17:07:34 Alexey Dobriyan wrote:
> Refactor PTRACE_PEEKUSR, PTRACE_POKEUSR implementation on i386.
> Ideas and concepts borrowed from utrace patchset by Roland McGrath.
>
> Patch adds only two new concepts: struct ptrace_usr_area and struct regset.
> The former describes registers accessible through PTRACE_PEEKUSR,
> PTRACE_POKEUSR in generic way. Where it starts, where it ends, if it's a hole
> (needed to know when to return 0 and -EIO).
>
> The latter is for abstracting various registers and operations on them
> (general-purpose regs, FPU regs, etc).
>
> Unlike utrace patchset, usr_area has direct pointer to correspoding
> register set instead of magic number in specific array.

The new code seems to be larger than the old code. Not sure
how that is an improvement?

Given the old bit operations weren't very nice, but then
the code rarely changes so it wasn't exactly a maintenance issue.

-Andi
 
Read Message
Read Message
Previous Topic: [RFC][PATCH 4/4] container freezer: do not unfreeze a frozen container when the system is resumed
Next Topic: Re: [RFC][PATCH 0/4] Container Freezer
Goto Forum:
  


Current Time: Fri Oct 10 13:16:01 GMT 2025

Total time taken to generate the page: 0.24502 seconds