OpenVZ Forum: Devel » [PATCH] diskquota: 32bit quota tools on 64bit architectures

Home » Mailing lists » Devel » [PATCH] diskquota: 32bit quota tools on 64bit architectures

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures [message #14176 is a reply to message #14153]

Mon, 18 June 2007 07:41

Vasily Tarasov
Messages: 1345
Registered: January 2006

Senior Member

On Fri, 2007-06-15 at 17:24 +0200, Arnd Bergmann wrote:
> On Friday 15 June 2007, Vasily Tarasov wrote:
> > I just noticed that we can not avoid the addition of packed attribute.
> > Look, for example:
> >
> > struct if_dqblk {
> > __u64 dqb_bhardlimit;
> > __u64 dqb_bsoftlimit;
> > __u64 dqb_curspace;
> > __u64 dqb_ihardlimit;
> > __u64 dqb_isoftlimit;
> > __u64 dqb_curinodes;
> > __u64 dqb_btime;
> > __u64 dqb_itime;
> > __u32 dqb_valid;
> > };
> >
> > sizeof(if_dqblk) = 0x48
> > On 32 bit: 0x44
> >
> > If I replace __u64/__u32 with compat equivalents - it will not help!
> > alligned attribute can _only_ _increase_ the size of structure, but not
> > decrease it.
>
> No, the gcc documentation isn't quite clear there, see the discussion about
> compat_u64 and compat_s64 types. It actually does the right thing when
> you use 'typedef __u64 __attribute__((aligned(64))) compat_64', as my
> patch does.
>
> Arnd <><
>

Wow!... Thank you for the explanation.
I'll resend the patch soon.

Vasily

Report message to a moderator

[Message index]

		[PATCH] diskquota: 32bit quota tools on 64bit architectures By: Anonymous Coward on Thu, 19 October 2006 12:30
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Alan Cox on Thu, 19 October 2006 13:03
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: rdunlap on Thu, 19 October 2006 15:20
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Christoph Hellwig on Thu, 19 October 2006 17:29
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Anonymous Coward on Fri, 20 October 2006 06:08
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Arnd Bergmann on Sat, 21 October 2006 16:28
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: David Chinner on Mon, 23 October 2006 02:12
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Anonymous Coward on Mon, 23 October 2006 10:50
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Anonymous Coward on Fri, 20 October 2006 05:58
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Anonymous Coward on Fri, 20 October 2006 06:28
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Christoph Hellwig on Fri, 20 October 2006 07:12
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Andi Kleen on Fri, 20 October 2006 12:21
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Vasily Tarasov on Fri, 15 June 2007 10:41
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Vasily Tarasov on Fri, 15 June 2007 11:00
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Arnd Bergmann on Fri, 15 June 2007 10:43
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Vasily Tarasov on Fri, 15 June 2007 14:48
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Arnd Bergmann on Fri, 15 June 2007 15:24
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Vasily Tarasov on Mon, 18 June 2007 07:41
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Mikael Pettersson on Fri, 15 June 2007 10:03
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Mikael Pettersson on Fri, 15 June 2007 11:08

Previous Topic:	[PATCH 16/17] Pid-NS(V3) Remove proc_mnts use for killing inodes
Next Topic:	[PATCH 12/17] Pid-NS(V3) Terminate processes in a ns when reaper is exiting.

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sat Aug 30 00:49:49 GMT 2025

Total time taken to generate the page: 0.08545 seconds