http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=6d205f120547043de663315698dcf5f0eaa31b5c

[PATCH] reiserfs: fix key decrementing
Vladimir Saveliev [Thu, 12 Apr 2007 06:28:44 +0000 (23:28 -0700)]
This patch fixes a bug in function decrementing a key of stat data item.

Offset of reiserfs keys are compared as signed values.  To set key offset
to maximal possible value maximal signed value has to be used.

This bug is responsible for severe reiserfs filesystem corruption which
shows itself as warning vs-13060.  reiserfsck fixes this corruption by
filesystem tree rebuilding.

Signed-off-by: Vladimir Saveliev <vs@namesys.com>
Cc: <reiserfs-dev@namesys.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

fs/reiserfs/item_ops.c          patch | blob | history


diff --git a/fs/reiserfs/item_ops.c b/fs/reiserfs/item_ops.c 
index b9b423b..9475557 100644 (file) 
--- a/fs/reiserfs/item_ops.c 
+++ b/fs/reiserfs/item_ops.c 
@@ -23,7 +23,7 @@ static void sd_decrement_key(struct cpu_key *key) 
 { 
        key->on_disk_key.k_objectid--; 
        set_cpu_key_k_type(key, TYPE_ANY); 
-       set_cpu_key_k_offset(key, (loff_t) (-1)); 
+       set_cpu_key_k_offset(key, (loff_t)(~0ULL >> 1)); 
 } 
  
 static int sd_is_left_mergeable(struct reiserfs_key *key, unsigned long bsize)