OpenVZ Forum: Devel » [PATCH] diskquota: 32bit quota tools on 64bit architectures

Home » Mailing lists » Devel » [PATCH] diskquota: 32bit quota tools on 64bit architectures

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures [message #14141 is a reply to message #7646]

Fri, 15 June 2007 10:43

Arnd Bergmann
Messages: 10
Registered: February 2006

Junior Member

On Friday 15 June 2007, Mikael Pettersson wrote:
> > --- linux-2.6.22-rc4-fixed/fs/quota.c.orig��2007-06-14 15:55:26.000000000 +0400
> > +++ linux-2.6.22-rc4-fixed/fs/quota.c�2007-06-14 19:50:13.000000000 +0400
> ...
> > +#if defined(CONFIG_X86_64) || defined(CONFIG_IA64)
> > +/*
> > + * This code works only for 32 bit quota tools over 64 bit OS (x86_64, ia64)
> > + * and is necessary due to alignment problems.
> > + */
>
> The #ifdef looks way too arch-specific. And isn't there a shared
> compat.c module somewhere that this should go into?
>

Only x86_64 and ia64 have this particular problem, the other architectures,
and hopefully all future 64 bit platforms with 32 bit user space use
the same alignment rules in elf32 and elf64.

Still, the patch should be converted to use the compat_u64 type and not
add an 'attribute((packed))' so that you _can_ use the same code on all
architectures. See my 'Introduce compat_u64 and compat_s64 types' patch
that I just posted in another thread.

Arnd <><

Report message to a moderator

[Message index]

		[PATCH] diskquota: 32bit quota tools on 64bit architectures By: Anonymous Coward on Thu, 19 October 2006 12:30
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Alan Cox on Thu, 19 October 2006 13:03
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: rdunlap on Thu, 19 October 2006 15:20
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Christoph Hellwig on Thu, 19 October 2006 17:29
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Anonymous Coward on Fri, 20 October 2006 06:08
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Arnd Bergmann on Sat, 21 October 2006 16:28
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: David Chinner on Mon, 23 October 2006 02:12
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Anonymous Coward on Mon, 23 October 2006 10:50
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Anonymous Coward on Fri, 20 October 2006 05:58
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Anonymous Coward on Fri, 20 October 2006 06:28
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Christoph Hellwig on Fri, 20 October 2006 07:12
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Andi Kleen on Fri, 20 October 2006 12:21
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Vasily Tarasov on Fri, 15 June 2007 10:41
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Vasily Tarasov on Fri, 15 June 2007 11:00
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Arnd Bergmann on Fri, 15 June 2007 10:43
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Vasily Tarasov on Fri, 15 June 2007 14:48
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Arnd Bergmann on Fri, 15 June 2007 15:24
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Vasily Tarasov on Mon, 18 June 2007 07:41
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Mikael Pettersson on Fri, 15 June 2007 10:03
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Mikael Pettersson on Fri, 15 June 2007 11:08

Previous Topic:	[PATCH 16/17] Pid-NS(V3) Remove proc_mnts use for killing inodes
Next Topic:	[PATCH 12/17] Pid-NS(V3) Terminate processes in a ns when reaper is exiting.

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sun Apr 19 21:18:29 GMT 2026

Total time taken to generate the page: 0.30423 seconds